AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland "[heap] Fix a formatting bug in --trace-incremental-marking. (patchset #2 id:20001 of https://codereview.chromium.org/2324623004/ )"

Browse Source 
This reverts commit 6c2a217ef7.

The performance regression in crbug.com/645411 was not caused
by the original CL.

TBR=mlippautz@chromium.org

Review-Url: https://codereview.chromium.org/2329983002
Cr-Commit-Position: refs/heads/master@{#39353}
This commit is contained in:
ulan 2016-09-12 06:03:52 -07:00 committed by Commit bot
parent 21cb110547
commit a26769629b
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/heap/heap.cc
View File

@ -810,7 +810,9 @@ void Heap::ScheduleIdleScavengeIfNeeded(int bytes_allocated) {
void Heap::FinalizeIncrementalMarking(GarbageCollectionReason gc_reason) {
if (FLAG_trace_incremental_marking) {
isolate()->PrintWithTimestamp("[IncrementalMarking] (%s).\n", gc_reason);
isolate()->PrintWithTimestamp(
"[IncrementalMarking] (%s).\n",
Heap::GarbageCollectionReasonToString(gc_reason));
}
HistogramTimerScope incremental_marking_scope(

2
src/isolate.h
View File

@ -1162,7 +1162,7 @@ class Isolate {
bool IsIsolateInBackground() { return is_isolate_in_background_; }
void PrintWithTimestamp(const char* format, ...);
PRINTF_FORMAT(2, 3) void PrintWithTimestamp(const char* format, ...);
protected:
explicit Isolate(bool enable_serializer);