Add regression test for the deoptimizer immediately followed by gc bug.
In addition to the regression test I changed the gc-extension to take a boolean flag specifying if compaction should be used (default is false, existing tests will not change behaviour) The regression test is disabled on arm and x64 with crankshaft enabled. I made a bug to track this: http://code.google.com/p/v8/issues/detail?id=1094 Review URL: http://codereview.chromium.org/6312118 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6619 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
73348e83ea
commit
a2aa84873e
@ -40,8 +40,12 @@ v8::Handle<v8::FunctionTemplate> GCExtension::GetNativeFunction(
|
||||
|
||||
|
||||
v8::Handle<v8::Value> GCExtension::GC(const v8::Arguments& args) {
|
||||
bool compact = false;
|
||||
// All allocation spaces other than NEW_SPACE have the same effect.
|
||||
Heap::CollectAllGarbage(false);
|
||||
if (args.Length() >= 1 && args[0]->IsBoolean()) {
|
||||
compact = args[0]->BooleanValue();
|
||||
}
|
||||
Heap::CollectAllGarbage(compact);
|
||||
return v8::Undefined();
|
||||
}
|
||||
|
||||
|
@ -112,6 +112,8 @@ regress/regress-3247124: SKIP
|
||||
# Test that currently fails with crankshaft on ARM.
|
||||
compiler/simple-osr: FAIL
|
||||
|
||||
# BUG (1094)
|
||||
regress/regress-deopt-gc: SKIP
|
||||
|
||||
##############################################################################
|
||||
[ $arch == x64 && $crankshaft ]
|
||||
@ -119,6 +121,8 @@ compiler/simple-osr: FAIL
|
||||
# BUG (1026) This test is currently flaky.
|
||||
compiler/simple-osr: SKIP
|
||||
|
||||
# BUG (1094)
|
||||
regress/regress-deopt-gc: SKIP
|
||||
|
||||
##############################################################################
|
||||
[ $arch == mips ]
|
||||
|
49
test/mjsunit/regress/regress-deopt-gc.js
Normal file
49
test/mjsunit/regress/regress-deopt-gc.js
Normal file
@ -0,0 +1,49 @@
|
||||
// Copyright 2011 the V8 project authors. All rights reserved.
|
||||
// Redistribution and use in source and binary forms, with or without
|
||||
// modification, are permitted provided that the following conditions are
|
||||
// met:
|
||||
//
|
||||
// * Redistributions of source code must retain the above copyright
|
||||
// notice, this list of conditions and the following disclaimer.
|
||||
// * Redistributions in binary form must reproduce the above
|
||||
// copyright notice, this list of conditions and the following
|
||||
// disclaimer in the documentation and/or other materials provided
|
||||
// with the distribution.
|
||||
// * Neither the name of Google Inc. nor the names of its
|
||||
// contributors may be used to endorse or promote products derived
|
||||
// from this software without specific prior written permission.
|
||||
//
|
||||
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
||||
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
||||
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
||||
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
||||
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
||||
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
||||
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
||||
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
||||
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
|
||||
// Flags: --allow-natives-syntax --expose-gc
|
||||
|
||||
// This tests that we can correctly handle a GC immediately after a function
|
||||
// has been deoptimized, even when we have an activation of this function on
|
||||
// the stack.
|
||||
|
||||
// Ensure that there is code objects before the code for the opt_me function.
|
||||
(function() { var a = 10; a++; })();
|
||||
|
||||
function opt_me() {
|
||||
deopt();
|
||||
}
|
||||
|
||||
function deopt() {
|
||||
// Make sure we don't inline this function
|
||||
try { var a = 42; } catch(o) {};
|
||||
%DeoptimizeFunction(opt_me);
|
||||
gc(true);
|
||||
}
|
||||
|
||||
|
||||
opt_me();
|
Loading…
Reference in New Issue
Block a user