AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup][diagnostics] Remove uses of DISALLOW_COPY_AND_ASSIGN

Browse Source 
Bug: v8:11074
Change-Id: I478f4390523ddf7cfb87dd22cef5ed331be5c875
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2558267
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71468}
This commit is contained in:
Zhi An Ng 2020-11-25 06:25:18 +00:00 committed by Commit Bot
parent d0414e876a
commit a312982153
8 changed files with 25 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/diagnostics/arm/disasm-arm.cc
View File

@ -54,6 +54,8 @@ class Decoder {
}
~Decoder() {}
Decoder(const Decoder&) = delete;
Decoder& operator=(const Decoder&) = delete;
// Writes one disassembled instruction into 'buffer' (0-terminated).
// Returns the length of the disassembled machine instruction in bytes.
@ -134,8 +136,6 @@ class Decoder {
const disasm::NameConverter& converter_;
Vector<char> out_buffer_;
int out_buffer_pos_;
DISALLOW_COPY_AND_ASSIGN(Decoder);
};
// Support for assertions in the Decoder formatting functions.

8
src/diagnostics/basic-block-profiler.h
View File

@ -29,6 +29,9 @@ class BasicBlockProfilerData {
V8_EXPORT_PRIVATE BasicBlockProfilerData(
OnHeapBasicBlockProfilerData js_heap_data);
BasicBlockProfilerData(const BasicBlockProfilerData&) = delete;
BasicBlockProfilerData& operator=(const BasicBlockProfilerData&) = delete;
size_t n_blocks() const {
DCHECK_EQ(block_ids_.size(), counts_.size());
return block_ids_.size();
@ -64,7 +67,6 @@ class BasicBlockProfilerData {
std::string schedule_;
std::string code_;
int hash_ = 0;
DISALLOW_COPY_AND_ASSIGN(BasicBlockProfilerData);
};
class BasicBlockProfiler {
@ -73,6 +75,8 @@ class BasicBlockProfiler {
BasicBlockProfiler() = default;
~BasicBlockProfiler() = default;
BasicBlockProfiler(const BasicBlockProfiler&) = delete;
BasicBlockProfiler& operator=(const BasicBlockProfiler&) = delete;
V8_EXPORT_PRIVATE static BasicBlockProfiler* Get();
BasicBlockProfilerData* NewData(size_t n_blocks);
@ -90,8 +94,6 @@ class BasicBlockProfiler {
private:
DataList data_list_;
base::Mutex data_list_mutex_;
DISALLOW_COPY_AND_ASSIGN(BasicBlockProfiler);
};
std::ostream& operator<<(std::ostream& os, const BasicBlockProfilerData& s);

4
src/diagnostics/compilation-statistics.h
View File

@ -25,6 +25,8 @@ struct AsPrintableStatistics {
class CompilationStatistics final : public Malloced {
public:
CompilationStatistics() = default;
CompilationStatistics(const CompilationStatistics&) = delete;
CompilationStatistics& operator=(const CompilationStatistics&) = delete;
class BasicStats {
public:
@ -81,8 +83,6 @@ class CompilationStatistics final : public Malloced {
PhaseKindMap phase_kind_map_;
PhaseMap phase_map_;
base::Mutex record_mutex_;
DISALLOW_COPY_AND_ASSIGN(CompilationStatistics);
};
std::ostream& operator<<(std::ostream& os, const AsPrintableStatistics& s);

8
src/diagnostics/eh-frame.h
View File

@ -72,6 +72,8 @@ class V8_EXPORT_PRIVATE EhFrameConstants final
class V8_EXPORT_PRIVATE EhFrameWriter {
public:
explicit EhFrameWriter(Zone* zone);
EhFrameWriter(const EhFrameWriter&) = delete;
EhFrameWriter& operator=(const EhFrameWriter&) = delete;
// The empty frame is a hack to trigger fp-based unwinding in Linux perf
// compiled with libunwind support when processing DWARF-based call graphs.
@ -206,8 +208,6 @@ class V8_EXPORT_PRIVATE EhFrameWriter {
Register base_register_;
int base_offset_;
ZoneVector<byte> eh_frame_buffer_;
DISALLOW_COPY_AND_ASSIGN(EhFrameWriter);
};
class V8_EXPORT_PRIVATE EhFrameIterator {
@ -290,6 +290,8 @@ class EhFrameDisassembler final {
: start_(start), end_(end) {
DCHECK_LT(start, end);
}
EhFrameDisassembler(const EhFrameDisassembler&) = delete;
EhFrameDisassembler& operator=(const EhFrameDisassembler&) = delete;
void DisassembleToStream(std::ostream& stream); // NOLINT
@ -301,8 +303,6 @@ class EhFrameDisassembler final {
const byte* start_;
const byte* end_;
DISALLOW_COPY_AND_ASSIGN(EhFrameDisassembler);
};
#endif

5
src/diagnostics/mips/disasm-mips.cc
View File

@ -52,6 +52,9 @@ class Decoder {
~Decoder() {}
Decoder(const Decoder&) = delete;
Decoder& operator=(const Decoder&) = delete;
// Writes one disassembled instruction into 'buffer' (0-terminated).
// Returns the length of the disassembled machine instruction in bytes.
int InstructionDecode(byte* instruction);
@ -150,8 +153,6 @@ class Decoder {
const disasm::NameConverter& converter_;
v8::internal::Vector<char> out_buffer_;
int out_buffer_pos_;
DISALLOW_COPY_AND_ASSIGN(Decoder);
};
// Support for assertions in the Decoder formatting functions.

5
src/diagnostics/mips64/disasm-mips64.cc
View File

@ -52,6 +52,9 @@ class Decoder {
~Decoder() {}
Decoder(const Decoder&) = delete;
Decoder& operator=(const Decoder&) = delete;
// Writes one disassembled instruction into 'buffer' (0-terminated).
// Returns the length of the disassembled machine instruction in bytes.
int InstructionDecode(byte* instruction);
@ -162,8 +165,6 @@ class Decoder {
const disasm::NameConverter& converter_;
v8::internal::Vector<char> out_buffer_;
int out_buffer_pos_;
DISALLOW_COPY_AND_ASSIGN(Decoder);
};
// Support for assertions in the Decoder formatting functions.

5
src/diagnostics/ppc/disasm-ppc.cc
View File

@ -52,6 +52,9 @@ class Decoder {
~Decoder() {}
Decoder(const Decoder&) = delete;
Decoder& operator=(const Decoder&) = delete;
// Writes one disassembled instruction into 'buffer' (0-terminated).
// Returns the length of the disassembled machine instruction in bytes.
int InstructionDecode(byte* instruction);
@ -85,8 +88,6 @@ class Decoder {
const disasm::NameConverter& converter_;
Vector<char> out_buffer_;
int out_buffer_pos_;
DISALLOW_COPY_AND_ASSIGN(Decoder);
};
// Support for assertions in the Decoder formatting functions.

5
src/diagnostics/s390/disasm-s390.cc
View File

@ -52,6 +52,9 @@ class Decoder {
~Decoder() {}
Decoder(const Decoder&) = delete;
Decoder& operator=(const Decoder&) = delete;
// Writes one disassembled instruction into 'buffer' (0-terminated).
// Returns the length of the disassembled machine instruction in bytes.
int InstructionDecode(byte* instruction);
@ -83,8 +86,6 @@ class Decoder {
const disasm::NameConverter& converter_;
Vector<char> out_buffer_;
int out_buffer_pos_;
DISALLOW_COPY_AND_ASSIGN(Decoder);
};
// Support for assertions in the Decoder formatting functions.