From a402686eb680ba83ddeaa0dc985c869af96a891d Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Fri, 15 Mar 2019 18:15:57 +0000 Subject: [PATCH] [turbolizer] Show whether a block is deferred in sequence view Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider Reviewed-by: Sigurd Schneider Cr-Commit-Position: refs/heads/master@{#60306} --- src/compiler/graph-visualizer.cc | 3 ++- tools/turbolizer/src/sequence-view.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc index 36e837f563..c14f66d165 100644 --- a/src/compiler/graph-visualizer.cc +++ b/src/compiler/graph-visualizer.cc @@ -1172,7 +1172,8 @@ std::ostream& operator<<(std::ostream& os, const InstructionBlockAsJSON& b) { const InstructionSequence* code = b.code_; os << "{"; os << "\"id\": " << block->rpo_number() << ","; - os << "\"deferred\": " << block->IsDeferred() << ","; + os << "\"deferred\": " << (block->IsDeferred() ? "true" : "false"); + os << ","; os << "\"loop_header\": " << block->IsLoopHeader() << ","; if (block->IsLoopHeader()) { os << "\"loop_end\": " << block->loop_end() << ","; diff --git a/tools/turbolizer/src/sequence-view.ts b/tools/turbolizer/src/sequence-view.ts index a796707c74..b0a85f1bd3 100644 --- a/tools/turbolizer/src/sequence-view.ts +++ b/tools/turbolizer/src/sequence-view.ts @@ -165,6 +165,7 @@ export class SequenceView extends TextView { } const sequenceBlock = createElement("div", "schedule-block"); + sequenceBlock.classList.toggle("deferred", block.deferred); const blockId = createElement("div", ["block-id", "com", "clickable"], block.id); blockId.onclick = mkBlockLinkHandler(block.id);