AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Correct nits in d8 ArrayBuffer() implementation

Browse Source 
TBR=jkummerow@chromium.org
BUG=none
TEST=external-array.js

Review URL: http://codereview.chromium.org/9185006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
danno@chromium.org 2012-01-11 15:10:56 +00:00
parent 6ce13906dc
commit a42da8e38d
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/d8.cc
View File

@ -387,8 +387,8 @@ Handle<Value> Shell::CreateExternalArray(const Arguments& args,
}
if (offset > array_buffer_length) {
return ThrowException(
String::New("byteOffset must be less than ArrayBuffer length."));
return ThrowException(
String::New("byteOffset must be less than ArrayBuffer length."));
}
if (args.Length() == 2) {

8
test/mjsunit/external-array.js
View File

@ -1,4 +1,4 @@
// Copyright 2011 the V8 project authors. All rights reserved.
// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@ -60,12 +60,6 @@ assertEquals(2, derived_uint32_2.length);
var derived_uint32_3 = new Uint32Array(ab,4,1);
assertEquals(1, derived_uint32_3.length);
// Resulting array length of zero should fail.
function abfunc2() {
new Uint32Array(ab,3);
}
assertThrows(abfunc2);
// If a given byteOffset and length references an area beyond the end of the
// ArrayBuffer an exception is raised.
function abfunc3() {