From a4993b73c51d1ac1a4ba681f72b015e95d4970d6 Mon Sep 17 00:00:00 2001 From: Igor Sheludko Date: Wed, 19 Dec 2018 17:21:38 +0100 Subject: [PATCH] [testrunner] Add mode detection for v8_enable_pointer_compression Tbr: machenbach@chromium.org Bug: v8:8562 Change-Id: If2242c6271d400e7c4c031e10871b06438c2636d Reviewed-on: https://chromium-review.googlesource.com/c/1384088 Commit-Queue: Igor Sheludko Reviewed-by: Jakob Kummerow Cr-Commit-Position: refs/heads/master@{#58373} --- BUILD.gn | 1 + tools/testrunner/base_runner.py | 4 ++++ tools/unittests/run_tests_test.py | 3 ++- tools/unittests/testdata/testroot1/v8_build_config.json | 3 ++- tools/unittests/testdata/testroot2/v8_build_config.json | 3 ++- 5 files changed, 11 insertions(+), 3 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 43bed27094..d80e0c3b6a 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1237,6 +1237,7 @@ action("v8_dump_build_config") { "v8_enable_jitless_mode=$v8_enable_jitless_mode", "v8_enable_verify_csa=$v8_enable_verify_csa", "v8_enable_lite_mode=$v8_enable_lite_mode", + "v8_enable_pointer_compression=$v8_enable_pointer_compression", ] if (v8_current_cpu == "mips" || v8_current_cpu == "mipsel" || diff --git a/tools/testrunner/base_runner.py b/tools/testrunner/base_runner.py index 5c8e985203..df1a5c49ad 100644 --- a/tools/testrunner/base_runner.py +++ b/tools/testrunner/base_runner.py @@ -188,6 +188,7 @@ class BuildConfig(object): self.embedded_builtins = build_config['v8_enable_embedded_builtins'] self.verify_csa = build_config['v8_enable_verify_csa'] self.lite_mode = build_config['v8_enable_lite_mode'] + self.pointer_compression = build_config['v8_enable_pointer_compression'] # Export only for MIPS target if self.arch in ['mips', 'mipsel', 'mips64', 'mips64el']: self.mips_arch_variant = build_config['mips_arch_variant'] @@ -222,6 +223,8 @@ class BuildConfig(object): detected_options.append('verify_csa') if self.lite_mode: detected_options.append('lite_mode') + if self.pointer_compression: + detected_options.append('pointer_compression') return '\n'.join(detected_options) @@ -669,6 +672,7 @@ class BaseTestRunner(object): "embedded_builtins": self.build_config.embedded_builtins, "verify_csa": self.build_config.verify_csa, "lite_mode": self.build_config.lite_mode, + "pointer_compression": self.build_config.pointer_compression, } def _create_test_config(self, options): diff --git a/tools/unittests/run_tests_test.py b/tools/unittests/run_tests_test.py index f9fa9865a3..28af9c2911 100755 --- a/tools/unittests/run_tests_test.py +++ b/tools/unittests/run_tests_test.py @@ -359,7 +359,8 @@ class SystemTest(unittest.TestCase): is_msan=True, is_tsan=True, is_ubsan_vptr=True, target_cpu='x86', v8_enable_i18n_support=False, v8_target_cpu='x86', v8_use_snapshot=False, v8_enable_embedded_builtins=False, - v8_enable_verify_csa=False, v8_enable_lite_mode=False) + v8_enable_verify_csa=False, v8_enable_lite_mode=False, + v8_enable_pointer_compression=False) result = run_tests( basedir, '--mode=Release', diff --git a/tools/unittests/testdata/testroot1/v8_build_config.json b/tools/unittests/testdata/testroot1/v8_build_config.json index 247d5b1d9b..79f9856a47 100644 --- a/tools/unittests/testdata/testroot1/v8_build_config.json +++ b/tools/unittests/testdata/testroot1/v8_build_config.json @@ -18,5 +18,6 @@ "v8_use_snapshot": true, "v8_enable_embedded_builtins": false, "v8_enable_verify_csa": false, - "v8_enable_lite_mode": false + "v8_enable_lite_mode": false, + "v8_enable_pointer_compression": true } diff --git a/tools/unittests/testdata/testroot2/v8_build_config.json b/tools/unittests/testdata/testroot2/v8_build_config.json index 247d5b1d9b..e4946321c5 100644 --- a/tools/unittests/testdata/testroot2/v8_build_config.json +++ b/tools/unittests/testdata/testroot2/v8_build_config.json @@ -18,5 +18,6 @@ "v8_use_snapshot": true, "v8_enable_embedded_builtins": false, "v8_enable_verify_csa": false, - "v8_enable_lite_mode": false + "v8_enable_lite_mode": false, + "v8_enable_pointer_compression": false }