From a49a279f566d15be421ef7ec5c2bdf35c6d6dac6 Mon Sep 17 00:00:00 2001 From: Maya Lekova Date: Mon, 11 Mar 2019 12:01:51 +0000 Subject: [PATCH] Revert "[presubmit] use the correct path for third party libraries" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit beaca8cf8b844c2f228ccf73039f3ab87f33e416. Reason for revert: Broke presubmit bot - https://ci.chromium.org/p/v8/builders/ci/V8%20Presubmit/2938 Note that the problem is not with this CL itself, but it uncovers some presubmit issue in Torque code. Until the latter is fixed, I'm reverting to unblock the tree. Original change's description: > [presubmit] use the correct path for third party libraries > > This CL ensures that presubmit script checks Torque files in third_party > dependencies. > > R=​szuend@chromium.org > TBR=machenbach@chromium.org,sergiyb@chromium.org > CC=​​yangguo@chromium.org > > No-Try: true > Change-Id: I9e2b193defbebe7ae85cfc5d14ce50c2ac367e9b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513674 > Reviewed-by: Tamer Tas > Reviewed-by: Simon Zünd > Commit-Queue: Tamer Tas > Cr-Commit-Position: refs/heads/master@{#60152} TBR=tmrts@chromium.org,szuend@chromium.org Change-Id: If8e2db0801f51ef737243ccfcc909d05fb42e3e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1514633 Reviewed-by: Maya Lekova Commit-Queue: Maya Lekova Cr-Commit-Position: refs/heads/master@{#60153} --- tools/v8_presubmit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/v8_presubmit.py b/tools/v8_presubmit.py index b7312e54a8..67105394c7 100755 --- a/tools/v8_presubmit.py +++ b/tools/v8_presubmit.py @@ -366,7 +366,7 @@ class TorqueLintProcessor(CacheableSourceFileProcessor): return name.endswith('.tq') def GetPathsToSearch(self): - dirs = ['third_party', 'src'] + dirs = ['third-party', 'src'] test_dirs = ['torque'] return dirs + [join('test', dir) for dir in test_dirs]