AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland "[debugger] Try to trigger pause-on-oom flakes with an extra printf"

Browse Source 
This is a reland of 8f7e915839

Original change's description:
> [debugger] Try to trigger pause-on-oom flakes with an extra printf
>
> We have an issue that we can't repro locally. Enable back the
> pause-on-oom tests with an extra printf with DEBUG. We will be able to
> better assess the failures when they appear on the bot.
>
> Bug: v8:10876
> Change-Id: I066539c4b5865ecb6f2e589e9543e8c9ebd4830b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474782
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70558}

Bug: v8:10876
Change-Id: Ice31c9455830da320ab057293c341f69e1f0c510
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484799
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70643}
This commit is contained in:
Santiago Aboy Solanes 2020-10-19 15:41:47 +01:00 committed by Commit Bot
parent 4d5e6fb301
commit a4a152ecc5
5 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/inspector/v8-debugger.cc
View File

@ -502,6 +502,10 @@ size_t HeapLimitForDebugging(size_t initial_heap_limit) {
size_t V8Debugger::nearHeapLimitCallback(void* data, size_t current_heap_limit,
size_t initial_heap_limit) {
V8Debugger* thisPtr = static_cast<V8Debugger*>(data);
// TODO(solanes, v8:10876): Remove when bug is solved.
#if DEBUG
printf("nearHeapLimitCallback\n");
#endif
thisPtr->m_originalHeapLimit = current_heap_limit;
thisPtr->m_scheduledOOMBreak = true;
v8::Local<v8::Context> context =

1
test/inspector/debugger/pause-on-oom-expected.txt
View File

@ -1,2 +1,3 @@
Check pause on OOM
nearHeapLimitCallback
reason: OOM

1
test/inspector/debugger/pause-on-oom-extrawide-expected.txt
View File

@ -1,2 +1,3 @@
Check pause on OOM
nearHeapLimitCallback
reason: OOM

1
test/inspector/debugger/pause-on-oom-wide-expected.txt
View File

@ -1,2 +1,3 @@
Check pause on OOM
nearHeapLimitCallback
reason: OOM

11
test/inspector/inspector.status
View File

@ -22,11 +22,12 @@
}], # ALWAYS
##############################################################################
['arch == x64 and mode == debug', {
# Flaky tests: https://crbug.com/v8/10876
'debugger/pause-on-oom-extrawide': [PASS, FAIL],
'debugger/pause-on-oom-wide': [PASS, FAIL],
}], # 'arch == x64 and mode == debug'
['mode != debug or dcheck_always_on', {
# Investigating flaky tests: https://crbug.com/v8/10876. Enable only on pure debug.
'debugger/pause-on-oom': [SKIP],
'debugger/pause-on-oom-wide': [SKIP],
'debugger/pause-on-oom-extrawide': [SKIP],
}], # 'mode != debug or dcheck_always_on'
##############################################################################
['system == android', {