AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Remove flag --shared-string-table-using-shared-space

Browse Source 
Since --shared-space is now enabled by default, we don't need this
flag for testing anymore.

Bug: v8:13267
Change-Id: Ib4c1111a75dbf93d05ccf3bac752c0ef089e3c15
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4194715
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#85488}
This commit is contained in:
Dominik Inführ 2023-01-25 17:01:41 +01:00 committed by V8 LUCI CQ
parent 17339eff04
commit a4a37c9303
4 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flags/flag-definitions.h
View File

@ -740,11 +740,6 @@ DEFINE_BOOL(trace_baseline_concurrent_compilation, false,
// Internalize into a shared string table in the shared isolate // Internalize into a shared string table in the shared isolate
DEFINE_BOOL(shared_string_table, false, "internalize strings into shared table") DEFINE_BOOL(shared_string_table, false, "internalize strings into shared table")
DEFINE_IMPLICATION(harmony_struct, shared_string_table) DEFINE_IMPLICATION(harmony_struct, shared_string_table)
DEFINE_BOOL(shared_string_table_using_shared_space, false,
"internalize strings into shared table")
DEFINE_IMPLICATION(shared_string_table_using_shared_space, shared_string_table)
DEFINE_IMPLICATION(shared_string_table_using_shared_space, shared_space)
DEFINE_IMPLICATION(harmony_struct, shared_string_table)
DEFINE_BOOL( DEFINE_BOOL(
always_use_string_forwarding_table, false, always_use_string_forwarding_table, false,
"use string forwarding table instead of thin strings for all strings") "use string forwarding table instead of thin strings for all strings")

3
tools/clusterfuzz/foozzie/v8_fuzz_flags.json
View File

@ -32,6 +32,5 @@
[0.1, "--turbo-force-mid-tier-regalloc"], [0.1, "--turbo-force-mid-tier-regalloc"],
[0.0001, "--simulate-errors"], [0.0001, "--simulate-errors"],
[0.1, "--minor-mc"], [0.1, "--minor-mc"],
[0.1, "--shared-string-table"], [0.1, "--shared-string-table"]
[0.1, "--shared-string-table-using-shared-space"]
] ]

1
tools/clusterfuzz/trials/clusterfuzz_trials_config.json
View File

@ -27,7 +27,6 @@
{"app_args": "--no-wasm-generic-wrapper", "app_name": "d8", "probability": 0.1}, {"app_args": "--no-wasm-generic-wrapper", "app_name": "d8", "probability": 0.1},
{"app_args": "--regexp-interpret-all", "app_name": "d8", "probability": 0.1}, {"app_args": "--regexp-interpret-all", "app_name": "d8", "probability": 0.1},
{"app_args": "--shared-string-table", "app_name": "d8", "probability": 0.1}, {"app_args": "--shared-string-table", "app_name": "d8", "probability": 0.1},
{"app_args": "--shared-string-table-using-shared-space", "app_name": "d8", "probability": 0.1},
{"app_args": "--simulate-errors", "app_name": "d8", "probability": 0.001}, {"app_args": "--simulate-errors", "app_name": "d8", "probability": 0.001},
{"app_args": "--stress-compaction-random", "app_name": "d8", "probability": 0.05}, {"app_args": "--stress-compaction-random", "app_name": "d8", "probability": 0.05},
{"app_args": "--stress-concurrent-inlining", "app_name": "d8", "probability": 0.25, "contradicts": ["--assert-types", "--jitless"]}, {"app_args": "--stress-concurrent-inlining", "app_name": "d8", "probability": 0.25, "contradicts": ["--assert-types", "--jitless"]},

1
tools/testrunner/testproc/fuzzer.py
View File

@ -46,7 +46,6 @@ EXTRA_FLAGS = [
(0.1, '--regexp-tier-up-ticks=10'), (0.1, '--regexp-tier-up-ticks=10'),
(0.1, '--regexp-tier-up-ticks=100'), (0.1, '--regexp-tier-up-ticks=100'),
(0.1, '--shared-string-table'), (0.1, '--shared-string-table'),
(0.1, '--shared-string-table-using-shared-space'),
(0.1, '--stress-background-compile'), (0.1, '--stress-background-compile'),
(0.1, '--stress-flush-code'), (0.1, '--stress-flush-code'),
(0.1, '--stress-lazy-source-positions'), (0.1, '--stress-lazy-source-positions'),