AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Turn ASSERTs to CHECKs in test-heap.cc

Browse Source 
This fixes unused variable compile failures in release builds introduced in r17887.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/76413004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
danno@chromium.org 2013-11-19 17:29:43 +00:00
parent 25fdcf27f2
commit a5f910eb2b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/cctest/test-heap.cc
View File

@ -3584,7 +3584,7 @@ TEST(EnsureAllocationSiteDependentCodesProcessed) {
// One allocation site should have been created. // One allocation site should have been created.
int new_count = AllocationSitesCount(heap); int new_count = AllocationSitesCount(heap);
ASSERT(new_count == (count + 1)); CHECK_EQ(new_count, (count + 1));
site = Handle<AllocationSite>::cast( site = Handle<AllocationSite>::cast(
global_handles->Create( global_handles->Create(
AllocationSite::cast(heap->allocation_sites_list()))); AllocationSite::cast(heap->allocation_sites_list())));
@ -3592,15 +3592,15 @@ TEST(EnsureAllocationSiteDependentCodesProcessed) {
CompileRun("%OptimizeFunctionOnNextCall(bar); bar();"); CompileRun("%OptimizeFunctionOnNextCall(bar); bar();");
DependentCode::GroupStartIndexes starts(site->dependent_code()); DependentCode::GroupStartIndexes starts(site->dependent_code());
ASSERT(starts.number_of_entries() >= 1); CHECK_GE(starts.number_of_entries(), 1);
int index = starts.at(DependentCode::kAllocationSiteTransitionChangedGroup); int index = starts.at(DependentCode::kAllocationSiteTransitionChangedGroup);
ASSERT(site->dependent_code()->is_code_at(index)); CHECK(site->dependent_code()->is_code_at(index));
Code* function_bar = site->dependent_code()->code_at(index); Code* function_bar = site->dependent_code()->code_at(index);
Handle<JSFunction> bar_handle = Handle<JSFunction> bar_handle =
v8::Utils::OpenHandle( v8::Utils::OpenHandle(
*v8::Handle<v8::Function>::Cast( *v8::Handle<v8::Function>::Cast(
CcTest::global()->Get(v8_str("bar")))); CcTest::global()->Get(v8_str("bar"))));
ASSERT(bar_handle->code() == function_bar); CHECK_EQ(bar_handle->code(), function_bar);
} }
// Now make sure that a gc should get rid of the function, even though we // Now make sure that a gc should get rid of the function, even though we
@ -3613,5 +3613,5 @@ TEST(EnsureAllocationSiteDependentCodesProcessed) {
// longer referred to by dependent_code(). // longer referred to by dependent_code().
DependentCode::GroupStartIndexes starts(site->dependent_code()); DependentCode::GroupStartIndexes starts(site->dependent_code());
int index = starts.at(DependentCode::kAllocationSiteTransitionChangedGroup); int index = starts.at(DependentCode::kAllocationSiteTransitionChangedGroup);
ASSERT(!(site->dependent_code()->is_code_at(index))); CHECK(!(site->dependent_code()->is_code_at(index)));
} }