AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

This does not match ES6 spec but is the behavior in both Firefox and WebKit/Blink.

Browse Source 
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/19086003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15655 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
dslomov@chromium.org 2013-07-15 07:43:46 +00:00
parent 1384094efc
commit a6419e3e47
4 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/typedarray.js
View File

@ -154,7 +154,7 @@ function TypedArraySet(obj, offset) {
var l = obj.length;
if (IS_UNDEFINED(l)) {
throw MakeTypeError("invalid_argument");
return;
}
if (intOffset + l > this.length) {
throw MakeRangeError("typed_array_set_source_too_large");

6
test/mjsunit/external-array-no-sse2.js
View File

@ -606,8 +606,10 @@ a61.set(a62)
assertArrayPrefix([1, 12], a61)
// Invalid source
assertThrows(function() { a.set(0) })
assertThrows(function() { a.set({}) })
a.set(0); // does not throw
assertArrayPrefix([1,2,3,4,5,6], a);
a.set({}); // does not throw
assertArrayPrefix([1,2,3,4,5,6], a);
// Test arraybuffer.slice

6
test/mjsunit/external-array.js
View File

@ -605,8 +605,10 @@ a61.set(a62)
assertArrayPrefix([1, 12], a61)
// Invalid source
assertThrows(function() { a.set(0) })
assertThrows(function() { a.set({}) })
a.set(0); // does not throw
assertArrayPrefix([1,2,3,4,5,6], a);
a.set({}); // does not throw
assertArrayPrefix([1,2,3,4,5,6], a);
// Test arraybuffer.slice

11
test/mjsunit/harmony/typedarrays.js
View File

@ -453,8 +453,15 @@ function TestTypedArraySet() {
// Invalid source
var a = new Uint16Array(50);
assertThrows(function() { a.set(0) }, TypeError);
assertThrows(function() { a.set({}) }, TypeError);
var expected = [];
for (i = 0; i < 50; i++) {
a[i] = i;
expected.push(i);
}
a.set(0);
assertArrayPrefix(expected, a);
a.set({});
assertArrayPrefix(expected, a);
assertThrows(function() { a.set.call({}) }, TypeError);
assertThrows(function() { a.set.call([]) }, TypeError);
}