AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove obsolete --turbo-try-catch flag.

Browse Source 
This removes the aforementioned flag which has been on by default for a
while now. Note that this does not control optimization decisions, only
the last-resort bailout in the graph builder.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1335543002

Cr-Commit-Position: refs/heads/master@{#30673}
This commit is contained in:
mstarzinger 2015-09-10 02:38:29 -07:00 committed by Commit bot
parent cfbe3f6443
commit a676da3ae0
6 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/ast-graph-builder.cc
View File

@ -1422,9 +1422,6 @@ void AstGraphBuilder::VisitTryCatchStatement(TryCatchStatement* stmt) {
// Evaluate the catch-block.
VisitInScope(stmt->catch_block(), stmt->scope(), context);
try_control.EndCatch();
// TODO(mstarzinger): Remove bailout once everything works.
if (!FLAG_turbo_try_catch) SetStackOverflow();
}

1
src/flag-definitions.h
View File

@ -445,7 +445,6 @@ DEFINE_BOOL(turbo_verify_allocation, DEBUG_BOOL,
DEFINE_BOOL(turbo_move_optimization, true, "optimize gap moves in TurboFan")
DEFINE_BOOL(turbo_jt, true, "enable jump threading in TurboFan")
DEFINE_BOOL(turbo_osr, true, "enable OSR in TurboFan")
DEFINE_BOOL(turbo_try_catch, true, "enable try-catch support in TurboFan")
DEFINE_BOOL(turbo_try_finally, false, "enable try-finally support in TurboFan")
DEFINE_BOOL(turbo_stress_loop_peeling, false,
"stress loop peeling optimization")

1
test/cctest/compiler/test-run-deopt.cc
View File

@ -63,7 +63,6 @@ TEST(DeoptSimpleInExpr) {
TEST(DeoptExceptionHandlerCatch) {
FLAG_allow_natives_syntax = true;
FLAG_turbo_try_catch = true;
FunctionTester T(
"(function f() {"

7
test/cctest/compiler/test-run-jsexceptions.cc
View File

@ -59,7 +59,6 @@ TEST(ThrowMessageDirectly) {
TEST(ThrowMessageIndirectly) {
i::FLAG_turbo_try_catch = true;
i::FLAG_turbo_try_finally = true;
static const char* src =
"(function(a, b) {"
@ -81,7 +80,6 @@ TEST(ThrowMessageIndirectly) {
TEST(Catch) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function(a,b) {"
" var r = '-';"
@ -100,7 +98,6 @@ TEST(Catch) {
TEST(CatchNested) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function(a,b) {"
" var r = '-';"
@ -124,7 +121,6 @@ TEST(CatchNested) {
TEST(CatchBreak) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function(a,b) {"
" var r = '-';"
@ -149,7 +145,6 @@ TEST(CatchBreak) {
TEST(CatchCall) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function(fun) {"
" var r = '-';"
@ -213,7 +208,6 @@ TEST(FinallyBreak) {
TEST(DeoptTry) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function f(a) {"
" try {"
@ -230,7 +224,6 @@ TEST(DeoptTry) {
TEST(DeoptCatch) {
i::FLAG_turbo_try_catch = true;
const char* src =
"(function f(a) {"
" try {"

1
test/cctest/test-api.cc
View File

@ -19253,7 +19253,6 @@ void CheckCorrectThrow(const char* script) {
TEST(AccessCheckThrows) {
i::FLAG_allow_natives_syntax = true;
i::FLAG_turbo_try_catch = true;
v8::V8::Initialize();
v8::V8::SetFailedAccessCheckCallbackFunction(&FailedAccessCheckThrows);
v8::Isolate* isolate = CcTest::isolate();

1
test/cctest/test-heap.cc
View File

@ -6354,7 +6354,6 @@ TEST(MessageObjectLeak) {
const char* flag = "--turbo-filter=*";
FlagList::SetFlagsFromString(flag, StrLength(flag));
FLAG_always_opt = true;
FLAG_turbo_try_catch = true;
FLAG_turbo_try_finally = true;
CompileRun(test);