AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

heap: Remove unused incremental marking should hurry flag

Browse Source 
The flag is unused.

Bug: chromium:1044630
Change-Id: Ib499cdd559451c9f23c3c98b187755ef6748bffc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030743
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66070}
This commit is contained in:
Michael Lippautz 2020-01-31 13:29:46 +01:00 committed by Commit Bot
parent b87586d29b
commit a6cf73e5db
3 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/heap/incremental-marking.cc
View File

@ -56,7 +56,6 @@ IncrementalMarking::IncrementalMarking(Heap* heap,
schedule_update_time_ms_(0),
bytes_marked_concurrently_(0),
is_compacting_(false),
should_hurry_(false),
was_activated_(false),
black_allocation_(false),
finalize_marking_completed_(false),
@ -291,7 +290,6 @@ void IncrementalMarking::Start(GarbageCollectionReason gc_reason) {
scheduled_bytes_to_mark_ = 0;
schedule_update_time_ms_ = start_time_ms_;
bytes_marked_concurrently_ = 0;
should_hurry_ = false;
was_activated_ = true;
{
@ -713,11 +711,6 @@ StepResult IncrementalMarking::EmbedderStep(double duration_ms) {
}
void IncrementalMarking::Hurry() {
// A scavenge may have pushed new objects on the marking deque (due to black
// allocation) even in COMPLETE state. This may happen if scavenges are
// forced e.g. in tests. It should not happen when COMPLETE was set when
// incremental marking finished and a regular GC was triggered after that
// because should_hurry_ will force a full GC.
if (!marking_worklists()->IsEmpty()) {
double start = 0.0;
if (FLAG_trace_incremental_marking) {
@ -765,7 +758,6 @@ void IncrementalMarking::Stop() {
}
}
IncrementalMarking::set_should_hurry(false);
heap_->isolate()->stack_guard()->ClearGC();
SetState(STOPPED);
is_compacting_ = false;
@ -798,9 +790,7 @@ void IncrementalMarking::MarkingComplete(CompletionAction action) {
// We will set the stack guard to request a GC now. This will mean the rest
// of the GC gets performed as soon as possible (we can't do a GC here in a
// record-write context). If a few things get allocated between now and then
// that shouldn't make us do a scavenge and keep being incremental, so we set
// the should-hurry flag to indicate that there can't be much work left to do.
set_should_hurry(true);
// that shouldn't make us do a scavenge and keep being incremental.
if (FLAG_trace_incremental_marking) {
heap()->isolate()->PrintWithTimestamp(
"[IncrementalMarking] Complete (normal).\n");

4
src/heap/incremental-marking.h
View File

@ -105,9 +105,6 @@ class V8_EXPORT_PRIVATE IncrementalMarking {
return state_;
}
bool should_hurry() const { return should_hurry_; }
void set_should_hurry(bool val) { should_hurry_ = val; }
bool finalize_marking_completed() const {
return finalize_marking_completed_;
}
@ -320,7 +317,6 @@ class V8_EXPORT_PRIVATE IncrementalMarking {
State state_;
bool is_compacting_;
bool should_hurry_;
bool was_activated_;
bool black_allocation_;
bool finalize_marking_completed_;

2
test/cctest/heap/test-heap.cc
View File

@ -2189,7 +2189,6 @@ TEST(InstanceOfStubWriteBarrier) {
g->Call(ctx, global, 0, nullptr).ToLocalChecked();
}
CcTest::heap()->incremental_marking()->set_should_hurry(true);
CcTest::CollectGarbage(OLD_SPACE);
}
@ -4985,7 +4984,6 @@ TEST(Regress3631) {
"for (var i = 0; i < 50; i++) {"
" weak_map.set(future_keys[i], i);"
"}");
heap->incremental_marking()->set_should_hurry(true);
CcTest::CollectGarbage(OLD_SPACE);
}