AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[crankshaft] HCall and HCallWithDescriptor should not override CalculateInferredType.

Browse Source 
We may set a proper HType on HCall or HCallWithDescriptor nodes, for
example for the InstanceOfStub, where we know that the result is a
boolean. So HCall and HCallWithDescriptor shall not ignore the type,
but pass through whatever we set (defaulting to Tagged).

R=jarin@chromium.org

Review-Url: https://codereview.chromium.org/2024033005
Cr-Commit-Position: refs/heads/master@{#36630}
This commit is contained in:
bmeurer 2016-05-31 23:41:35 -07:00 committed by Commit bot
parent 0f06f80f6f
commit a6f6d8ad2e
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/crankshaft/hydrogen-instructions.h
View File

@ -2161,8 +2161,6 @@ class HCall : public HTemplateInstruction<V> {
this->SetAllSideEffects();
}
HType CalculateInferredType() final { return HType::Tagged(); }
virtual int argument_count() const {
return argument_count_;
}
@ -2240,8 +2238,6 @@ class HCallWithDescriptor final : public HInstruction {
DECLARE_CONCRETE_INSTRUCTION(CallWithDescriptor)
HType CalculateInferredType() final { return HType::Tagged(); }
// Defines whether this instruction corresponds to a JS call at tail position.
TailCallMode syntactic_tail_call_mode() const {
return SyntacticTailCallModeField::decode(bit_field_);