From a70e537272fda03437471191e1d8b8c546e078dc Mon Sep 17 00:00:00 2001
From: Adam Klein <adamk@chromium.org>
Date: Thu, 20 Dec 2018 15:18:51 -0800
Subject: [PATCH] [d8] Remove unnecessary calls to v8::Global::Reset() in Realm
 teardown

Change-Id: Id4f99539b8583cef56fd33d2e939a2d6024384f9
Reviewed-on: https://chromium-review.googlesource.com/c/1387989
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58452}
---
 src/d8.cc | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/d8.cc b/src/d8.cc
index 98bc56ad25..c4bc8b554f 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -939,14 +939,9 @@ PerIsolateData::RealmScope::~RealmScope() {
     Global<Context>& realm = data_->realms_[i];
     if (realm.IsEmpty()) continue;
     DisposeModuleEmbedderData(realm.Get(data_->isolate_));
-    // TODO(adamk): No need to reset manually, Globals reset when destructed.
-    realm.Reset();
   }
   data_->realm_count_ = 0;
   delete[] data_->realms_;
-  // TODO(adamk): No need to reset manually, Globals reset when destructed.
-  if (!data_->realm_shared_.IsEmpty())
-    data_->realm_shared_.Reset();
 }