AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] Ensure progress of default task runners in inspector tests

Browse Source 
Bug: v8:10747, chromium:1098187
Change-Id: I0215d2d85db4dd1d7fa376a0982cda5658f1683d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315982
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69387}
This commit is contained in:
Ulan Degenbaev 2020-08-13 16:43:08 +02:00 committed by Commit Bot
parent d430610c0e
commit a7eff8cbbf
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/inspector/inspector.status
View File

@ -97,4 +97,29 @@
'cpu-profiler/console-profile-wasm': [SKIP],
}], # 'tsan == True'
##############################################################################
['gc_stress or gc_fuzzer or variant == stress_incremental_marking', {
# Skip tests that fail with GC stress: https://crbug.com/v8/10748
'debugger/get-possible-breakpoints': [SKIP],
'debugger/get-possible-breakpoints-array-literal': [SKIP],
'debugger/get-possible-breakpoints-master': [SKIP],
'debugger/regression-424142': [SKIP],
'debugger/return-break-locations': [SKIP],
'debugger/set-breakpoint-at-last-line': [SKIP],
'debugger/set-breakpoint-breaks-on-first-breakable-location': [SKIP],
'runtime-call-stats/collection': [SKIP],
'runtime/internal-properties-entries': [SKIP],
'type-profiler/type-profile-start-stop': [SKIP],
}], # gc_stress
##############################################################################
['variant == stress_js_bg_compile_wasm_code_gc', {
# Skip tests that fail with GC stress: https://crbug.com/v8/10748
'debugger/wasm-debug-command': [SKIP],
'debugger/wasm-global-names': [SKIP],
'debugger/wasm-set-breakpoint-liftoff': [SKIP],
'debugger/wasm-source': [SKIP],
'debugger/wasm-stepping-with-skiplist': [SKIP],
}], # stress_js_bg_compile_wasm_code_gc
]

7
test/inspector/task-runner.cc
View File

@ -4,6 +4,8 @@
#include "test/inspector/task-runner.h"
#include "include/libplatform/libplatform.h"
#if !defined(_WIN32) && !defined(_WIN64)
#include <unistd.h> // NOLINT
#endif // !defined(_WIN32) && !defined(_WIN64)
@ -75,6 +77,11 @@ void TaskRunner::RunMessageLoop(bool only_protocol) {
task->Run(data_.get());
delete task;
}
// Also pump isolate's foreground task queue to ensure progress.
// This can be removed once https://crbug.com/v8/10747 is fixed.
while (v8::platform::PumpMessageLoop(v8::internal::V8::GetCurrentPlatform(),
isolate())) {
}
}
}