AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[x64] Generate test reg,reg instead of cmp reg,0.

Browse Source 
The instruction sequence is shorter and saves decoding bandwidth.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/916543004

Cr-Commit-Position: refs/heads/master@{#26734}
This commit is contained in:
Benedikt Meurer 2015-02-19 08:45:35 +01:00
parent b00ea0f125
commit a7fb5ed400
1 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/compiler/x64/code-generator-x64.cc
View File

@ -210,6 +210,27 @@ class OutOfLineTruncateDoubleToI FINAL : public OutOfLineCode {
} while (0) } while (0)
#define ASSEMBLE_CMP(cmp_instr, test_instr) \
do { \
if (HasImmediateInput(instr, 1)) { \
if (instr->InputAt(0)->IsRegister()) { \
if (i.InputInt32(1) == 0) { \
__ test_instr(i.InputRegister(0), i.InputRegister(0)); \
} else { \
__ cmp_instr(i.InputRegister(0), i.InputImmediate(1)); \
} \
} else { \
__ cmp_instr(i.InputOperand(0), i.InputImmediate(1)); \
} \
} else { \
if (instr->InputAt(1)->IsRegister()) { \
__ cmp_instr(i.InputRegister(0), i.InputRegister(1)); \
} else { \
__ cmp_instr(i.InputRegister(0), i.InputOperand(1)); \
} \
} \
} while (0)
#define ASSEMBLE_MULT(asm_instr) \ #define ASSEMBLE_MULT(asm_instr) \
do { \ do { \
if (HasImmediateInput(instr, 1)) { \ if (HasImmediateInput(instr, 1)) { \
@ -588,10 +609,10 @@ void CodeGenerator::AssembleArchInstruction(Instruction* instr) {
ASSEMBLE_BINOP(andq); ASSEMBLE_BINOP(andq);
break; break;
case kX64Cmp32: case kX64Cmp32:
ASSEMBLE_BINOP(cmpl); ASSEMBLE_CMP(cmpl, testl);
break; break;
case kX64Cmp: case kX64Cmp:
ASSEMBLE_BINOP(cmpq); ASSEMBLE_CMP(cmpq, testq);
break; break;
case kX64Test32: case kX64Test32:
ASSEMBLE_BINOP(testl); ASSEMBLE_BINOP(testl);