AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Better comment for a bailout case in the SafeStackFrameIterator.

Browse Source 
We should explain why we default to StackFrame::OPTIMIZED rather
than StackFrame::INTERPRETED when we don't have a great idea
about what kind of frame we are looking at.

Bug: 
Change-Id: I9d3cc84def6164ef79a4792822d52c11dfe8a448
Reviewed-on: https://chromium-review.googlesource.com/668450
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48565}
This commit is contained in:
Mike Stanton 2017-09-15 15:43:53 +02:00 committed by Commit Bot
parent 31cde16eee
commit a8db822577
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/frames.cc
View File

@ -238,6 +238,11 @@ SafeStackFrameIterator::SafeStackFrameIterator(
}
} else {
// Mark the frame as OPTIMIZED if we cannot determine its type.
// We chose OPTIMIZED rather than INTERPRETED because it's closer to
// the original value of StackFrame::JAVA_SCRIPT here, in that JAVA_SCRIPT
// referred to full-codegen frames (now removed from the tree), and
// OPTIMIZED refers to turbofan frames, both of which are generated
// code. INTERPRETED frames refer to bytecode.
// The frame anyways will be skipped.
type = StackFrame::OPTIMIZED;
// Top frame is incomplete so we cannot reliably determine its type.