AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Update test and rebaseline

Browse Source 
BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/408183002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22520 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
verwaest@chromium.org 2014-07-22 09:44:56 +00:00
parent 1b8073ca3e
commit a973e3a16e
3 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/objects.cc
View File

@ -3107,8 +3107,10 @@ MaybeHandle<Object> Object::AddDataProperty(LookupIterator* it,
StrictMode strict_mode,
StoreFromKeyed store_mode) {
ASSERT(!it->GetReceiver()->IsJSProxy());
// Transitions to data properties of value wrappers are not observable.
if (!it->GetReceiver()->IsJSObject()) return value;
if (!it->GetReceiver()->IsJSObject()) {
// TODO(verwaest): Throw a TypeError with a more specific message.
return WriteToReadOnlyProperty(it, value, strict_mode);
}
Handle<JSObject> receiver = Handle<JSObject>::cast(it->GetReceiver());
// If the receiver is a JSGlobalProxy, store on the prototype (JSGlobalObject)

18
test/webkit/fast/js/primitive-property-access-edge-cases-expected.txt
View File

@ -29,15 +29,15 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS checkGet(1, Number) is true
PASS checkGet('hello', String) is true
PASS checkGet(true, Boolean) is true
FAIL checkSet(1, Number) should be true. Was false.
FAIL checkSet('hello', String) should be true. Was false.
FAIL checkSet(true, Boolean) should be true. Was false.
PASS checkSet(1, Number) is true
PASS checkSet('hello', String) is true
PASS checkSet(true, Boolean) is true
PASS checkGetStrict(1, Number) is true
PASS checkGetStrict('hello', String) is true
PASS checkGetStrict(true, Boolean) is true
FAIL checkSetStrict(1, Number) should be true. Was false.
FAIL checkSetStrict('hello', String) should be true. Was false.
FAIL checkSetStrict(true, Boolean) should be true. Was false.
PASS checkSetStrict(1, Number) is true
PASS checkSetStrict('hello', String) is true
PASS checkSetStrict(true, Boolean) is true
PASS checkRead(1, Number) is true
PASS checkRead('hello', String) is true
PASS checkRead(true, Boolean) is true
@ -47,9 +47,9 @@ PASS checkWrite(true, Boolean) is true
PASS checkReadStrict(1, Number) is true
PASS checkReadStrict('hello', String) is true
PASS checkReadStrict(true, Boolean) is true
FAIL checkWriteStrict(1, Number) should throw an exception. Was true.
FAIL checkWriteStrict('hello', String) should throw an exception. Was true.
FAIL checkWriteStrict(true, Boolean) should throw an exception. Was true.
PASS checkWriteStrict(1, Number) threw exception TypeError: Cannot assign to read only property 'foo' of 1.
PASS checkWriteStrict('hello', String) threw exception TypeError: Cannot assign to read only property 'foo' of hello.
PASS checkWriteStrict(true, Boolean) threw exception TypeError: Cannot assign to read only property 'foo' of true.
PASS checkNumericGet(1, Number) is true
PASS checkNumericGet('hello', String) is true
PASS checkNumericGet(true, Boolean) is true

2
test/webkit/fast/js/read-modify-eval-expected.txt
View File

@ -42,7 +42,7 @@ PASS preDecTest(); is true
PASS postIncTest(); is true
PASS postDecTest(); is true
PASS primitiveThisTest.call(1); is true
FAIL strictThisTest.call(1); should throw an exception. Was true.
PASS strictThisTest.call(1); threw exception TypeError: Cannot assign to read only property 'value' of 1.
PASS successfullyParsed is true
TEST COMPLETE