AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove unused external references

Browse Source 
git grep 'V(\w*' src/external-reference.h | sed 's/.*V(\(\w*\).*/\1/' | sort | uniq | while read e; do echo -n "$e "; git grep "ExternalReference::$e" | wc -l; done

Bug: v8:7754
Change-Id: I702ada4a98a1f1d51b2f4e890dbb5a7abb8c5731
Reviewed-on: https://chromium-review.googlesource.com/1122227
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54136}
This commit is contained in:
jgruber 2018-07-02 13:54:24 +02:00 committed by Commit Bot
parent ec7249f274
commit a99df0b39a
4 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/debug/debug.h
View File

@ -377,10 +377,6 @@ class Debug {
return reinterpret_cast<Address>(&hook_on_function_call_);
}
Address last_step_action_address() {
return reinterpret_cast<Address>(&thread_local_.last_step_action_);
}
Address suspended_generator_address() {
return reinterpret_cast<Address>(&thread_local_.suspended_generator_);
}

22
src/external-reference.cc
View File

@ -57,8 +57,6 @@ namespace internal {
constexpr double double_min_int_constant = kMinInt;
constexpr double double_one_half_constant = 0.5;
constexpr double double_minus_one_half_constant = -0.5;
constexpr double double_negative_infinity_constant = -V8_INFINITY;
constexpr uint64_t double_the_hole_nan_constant = kHoleNanInt64;
constexpr double double_uint32_bias_constant =
static_cast<double>(kMaxUInt32) + 1;
@ -480,16 +478,6 @@ ExternalReference ExternalReference::address_of_one_half() {
reinterpret_cast<Address>(&double_one_half_constant));
}
ExternalReference ExternalReference::address_of_minus_one_half() {
return ExternalReference(
reinterpret_cast<Address>(&double_minus_one_half_constant));
}
ExternalReference ExternalReference::address_of_negative_infinity() {
return ExternalReference(
reinterpret_cast<Address>(&double_negative_infinity_constant));
}
ExternalReference ExternalReference::address_of_the_hole_nan() {
return ExternalReference(
reinterpret_cast<Address>(&double_the_hole_nan_constant));
@ -864,11 +852,6 @@ ExternalReference ExternalReference::debug_hook_on_function_call_address(
return ExternalReference(isolate->debug()->hook_on_function_call_address());
}
ExternalReference ExternalReference::debug_execution_mode_address(
Isolate* isolate) {
return ExternalReference(isolate->debug_execution_mode_address());
}
ExternalReference ExternalReference::runtime_function_table_address(
Isolate* isolate) {
return ExternalReference(
@ -938,11 +921,6 @@ ExternalReference ExternalReference::mod_two_doubles_operation() {
Redirect(FUNCTION_ADDR(modulo_double_double), BUILTIN_FP_FP_CALL));
}
ExternalReference ExternalReference::debug_last_step_action_address(
Isolate* isolate) {
return ExternalReference(isolate->debug()->last_step_action_address());
}
ExternalReference ExternalReference::debug_suspended_generator_address(
Isolate* isolate) {
return ExternalReference(isolate->debug()->suspended_generator_address());

4
src/external-reference.h
View File

@ -60,10 +60,8 @@ class StatsCounter;
V(debug_is_active_address, "Debug::is_active_address()") \
V(debug_hook_on_function_call_address, \
"Debug::hook_on_function_call_address()") \
V(debug_execution_mode_address, "Isolate::debug_execution_mode()") \
V(runtime_function_table_address, \
"Runtime::runtime_function_table_address()") \
V(debug_last_step_action_address, "Debug::step_in_enabled_address()") \
V(is_profiling_address, "Isolate::is_profiling") \
V(debug_suspended_generator_address, \
"Debug::step_suspended_generator_address()") \
@ -76,8 +74,6 @@ class StatsCounter;
V(address_of_float_abs_constant, "float_absolute_constant") \
V(address_of_float_neg_constant, "float_negate_constant") \
V(address_of_min_int, "LDoubleConstant::min_int") \
V(address_of_minus_one_half, "double_constants.minus_one_half") \
V(address_of_negative_infinity, "LDoubleConstant::negative_infinity") \
V(address_of_one_half, "LDoubleConstant::one_half") \
V(address_of_the_hole_nan, "the_hole_nan") \
V(address_of_uint32_bias, "uint32_bias") \

4
src/isolate.h
View File

@ -1260,10 +1260,6 @@ class Isolate : private HiddenFactory {
return reinterpret_cast<Address>(&handle_scope_implementer_);
}
Address debug_execution_mode_address() {
return reinterpret_cast<Address>(&debug_execution_mode_);
}
void SetAtomicsWaitCallback(v8::Isolate::AtomicsWaitCallback callback,
void* data);
void RunAtomicsWaitCallback(v8::Isolate::AtomicsWaitEvent event,