From aa30ca13fd6f9148ad019fc730527085813f2700 Mon Sep 17 00:00:00 2001 From: Dan Elphick Date: Wed, 8 May 2019 16:56:43 +0100 Subject: [PATCH] [turbofan] Fix source positions for inlined functions Puts back source position collection for inlined functions when concurrent inlining is not enabled. Bug: v8:8510 Change-Id: I8e8a7ef15c0854b1e37299a007303b3213988cf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601266 Auto-Submit: Dan Elphick Commit-Queue: Maya Lekova Reviewed-by: Maya Lekova Cr-Commit-Position: refs/heads/master@{#61362} --- src/compiler/js-inlining.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/compiler/js-inlining.cc b/src/compiler/js-inlining.cc index eb24fa9b8c..bcfb4e00e7 100644 --- a/src/compiler/js-inlining.cc +++ b/src/compiler/js-inlining.cc @@ -447,6 +447,10 @@ Reduction JSInliner::ReduceJSCall(Node* node) { // it never gets flushed, so the following check should always hold true. CHECK(is_compiled_scope.is_compiled()); + if (!FLAG_concurrent_inlining && info_->is_source_positions_enabled()) { + SharedFunctionInfo::EnsureSourcePositionsAvailable(isolate(), shared_info); + } + TRACE("Inlining %s into %s%s\n", shared_info->DebugName()->ToCString().get(), info_->shared_info()->DebugName()->ToCString().get(), (exception_target != nullptr) ? " (inside try-block)" : "");