AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[turbofan] Enable --verify-simplified-lowering in debug"

Browse Source 
This reverts commit 23b178b540.

Reason for revert: Speculative revert due to https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/945522/overview

Original change's description:
> [turbofan] Enable --verify-simplified-lowering in debug
>
> Bug: v8:12619
> Change-Id: I3b9f82a21c9454ff37036e8abcf73862e38f1fc9
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494243
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#79338}

Bug: v8:12619
Change-Id: Ia879b53e1b0a07109f0420fdf954b110f45abf58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3497339
Auto-Submit: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#79354}
This commit is contained in:
Nico Hartmann 2022-03-03 18:03:42 +00:00 committed by V8 LUCI CQ
parent 995217a31b
commit aaedd8b788
3 changed files with 7 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compiler/simplified-lowering-verifier.cc
View File

@ -41,10 +41,7 @@ void SimplifiedLoweringVerifier::CheckAndSet(Node* node, const Type& type,
node_type_str.str().c_str());
}
} else {
// We store the type inferred by the verification pass. We do not update
// the node's type directly, because following phases might encounter
// unsound types as long as the verification is not complete.
SetType(node, type);
NodeProperties::SetType(node, type);
}
SetTruncation(node, GeneralizeTruncation(trunc, type));
}

25
src/compiler/simplified-lowering-verifier.h
View File

@ -16,7 +16,6 @@ class OperationTyper;
class SimplifiedLoweringVerifier final {
public:
struct PerNodeData {
Type type = Type::None();
Truncation truncation = Truncation::Any(IdentifyZeros::kDistinguishZeros);
};
@ -39,19 +38,6 @@ class SimplifiedLoweringVerifier final {
return type_guards_.find(node) != type_guards_.end();
}
void ResizeDataIfNecessary(Node* node) {
if (data_.size() <= node->id()) {
data_.resize(node->id() + 1);
}
DCHECK_EQ(data_[node->id()].truncation,
Truncation::Any(IdentifyZeros::kDistinguishZeros));
}
void SetType(Node* node, const Type& type) {
ResizeDataIfNecessary(node);
data_[node->id()].type = type;
}
Type InputType(Node* node, int input_index) const {
// TODO(nicohartmann): Check that inputs are typed, once all operators are
// supported.
@ -59,16 +45,15 @@ class SimplifiedLoweringVerifier final {
if (NodeProperties::IsTyped(input)) {
return NodeProperties::GetType(input);
}
// For nodes that have not been typed before SL, we use the type that has
// been inferred by the verifier.
if (input->id() < data_.size()) {
return data_[input->id()].type;
}
return Type::None();
}
void SetTruncation(Node* node, const Truncation& truncation) {
ResizeDataIfNecessary(node);
if (data_.size() <= node->id()) {
data_.resize(node->id() + 1);
}
DCHECK_EQ(data_[node->id()].truncation,
Truncation::Any(IdentifyZeros::kDistinguishZeros));
data_[node->id()].truncation = truncation;
}

3
src/flags/flag-definitions.h
View File

@ -571,8 +571,7 @@ DEFINE_BOOL(assert_types, false,
// TODO(tebbi): Support allocating types from background thread.
DEFINE_NEG_IMPLICATION(assert_types, concurrent_recompilation)
// Enable verification of SimplifiedLowering in debug builds.
DEFINE_BOOL(verify_simplified_lowering, DEBUG_BOOL,
DEFINE_BOOL(verify_simplified_lowering, false,
"verify graph generated by simplified lowering")
DEFINE_BOOL(trace_compilation_dependencies, false, "trace code dependencies")