AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Make MarkInlinedFunctionsCode visitor private.

Browse Source 
Now that the VisitCode visitor is actually marking through to inlined
code objects (as opposed to the VisitJSFunction visitor), we can make
this helper method private again.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/1422853008

Cr-Commit-Position: refs/heads/master@{#31860}
This commit is contained in:
mstarzinger 2015-11-06 07:18:00 -08:00 committed by Commit bot
parent 8c32ef6ee8
commit aca2176500
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/heap/mark-compact.cc
View File

@ -1460,8 +1460,9 @@ void MarkCompactCollector::PrepareThreadForCodeFlushing(Isolate* isolate,
MarkBit code_mark = Marking::MarkBitFrom(code);
MarkObject(code, code_mark);
if (frame->is_optimized()) {
MarkCompactMarkingVisitor::MarkInlinedFunctionsCode(heap(),
frame->LookupCode());
Code* optimized_code = frame->LookupCode();
MarkBit optimized_code_mark = Marking::MarkBitFrom(optimized_code);
MarkObject(optimized_code, optimized_code_mark);
}
}
}

8
src/heap/objects-visiting.h
View File

@ -370,10 +370,6 @@ class StaticMarkingVisitor : public StaticVisitorBase {
// Skip the weak next code link in a code object.
INLINE(static void VisitNextCodeLink(Heap* heap, Object** slot)) {}
// Mark non-optimize code for functions inlined into the given optimized
// code. This will prevent it from being flushed.
static void MarkInlinedFunctionsCode(Heap* heap, Code* code);
protected:
INLINE(static void VisitMap(Map* map, HeapObject* object));
INLINE(static void VisitCode(Map* map, HeapObject* object));
@ -397,6 +393,10 @@ class StaticMarkingVisitor : public StaticVisitorBase {
// references, possibly treating some entries weak.
static void MarkOptimizedCodeMap(Heap* heap, FixedArray* code_map);
// Mark non-optimized code for functions inlined into the given optimized
// code. This will prevent it from being flushed.
static void MarkInlinedFunctionsCode(Heap* heap, Code* code);
// Code flushing support.
INLINE(static bool IsFlushable(Heap* heap, JSFunction* function));
INLINE(static bool IsFlushable(Heap* heap, SharedFunctionInfo* shared_info));