From ad2fc6568098aa665a44b5b2415e8263d89d4e10 Mon Sep 17 00:00:00 2001 From: Leszek Swirski Date: Fri, 16 Dec 2022 12:27:21 +0100 Subject: [PATCH] Revert "[compiler] Enable feedback collection in generic lowering" This reverts commit e63bae121b78c9dee06b0489d971c9c98df7737b. Reason for revert: Speculatively reverting since NCI is disabled and _WithFeedback builtins are hot in speedometer. Original change's description: > [compiler] Enable feedback collection in generic lowering > > Turbofan now has support for generating generic code in two variants, > with and without feedback collection. Currently, feedback is collected > only for some load and store operators (historical reasons). > > This CL enables feedback collection for (almost) all operators by > default. The exception in the default TF configuration are call and > construct variants (see also https://crrev.com/c/2276042). In NCI mode, > all operators collect feedback. > > Regression have looked acceptable in our benchmarks so far. This is an > experiment to see impact on real world. If successful, the > non-collecting variants can be removed. > > Bug: v8:8888 > Change-Id: I0dddc7113ce94071552d5c4d992471db5ac5f989 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2239571 > Auto-Submit: Jakob Gruber > Reviewed-by: Georg Neis > Commit-Queue: Georg Neis > Cr-Commit-Position: refs/heads/master@{#68710} Bug: v8:8888 Change-Id: I5622528383c6194ccda639041291900144465782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4110858 Reviewed-by: Jakob Linke Commit-Queue: Leszek Swirski Auto-Submit: Leszek Swirski Cr-Commit-Position: refs/heads/main@{#84904} --- src/flags/flag-definitions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 073061f7b1..cadc702a90 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -976,7 +976,7 @@ DEFINE_BOOL(turbo_optimize_apply, true, "optimize Function.prototype.apply") DEFINE_BOOL(turbo_optimize_math_minmax, true, "optimize call math.min/max with double array") -DEFINE_BOOL(turbo_collect_feedback_in_generic_lowering, true, +DEFINE_BOOL(turbo_collect_feedback_in_generic_lowering, false, "enable experimental feedback collection in generic lowering.") DEFINE_BOOL(isolate_script_cache_ageing, true, "enable ageing of the isolate script cache.")