AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove unwarranted assumptions about inlining from a debugger test.

Browse Source 
Review URL: https://chromiumcodereview.appspot.com/10239003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
erik.corry@gmail.com 2012-04-26 11:58:34 +00:00
parent 657ffd8815
commit ad4f2b996b
2 changed files with 36 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
test/mjsunit/debug-evaluate-locals-optimized-double.js
View File

@ -56,6 +56,11 @@ function arraySum(arr) {
return arr.reduce(function (a, b) { return a + b; }, 0);
}
function isCurrentlyOptimized(fun) {
// See runtime.cc.
return (%GetOptimizationStatus(fun) & 1) != 0;
}
function listener(event, exec_state, event_data, data) {
try {
if (event == Debug.DebugEvent.Break)
@ -148,23 +153,22 @@ function listener(event, exec_state, event_data, data) {
assertFalse(frame.isConstructCall());
}
// When function f is optimized (1 means YES, see runtime.cc) we
// expect an optimized frame for f with g1, g2 and g3 inlined.
if (%GetOptimizationStatus(f) == 1) {
if (i == 1 || i == 2 || i == 3) {
assertTrue(frame.isOptimizedFrame());
assertTrue(frame.isInlinedFrame());
assertEquals(4 - i, frame.inlinedFrameIndex());
} else if (i == 4) {
assertTrue(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
} else {
assertFalse(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
}
if (i > 4) {
assertFalse(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
}
}
// When function f is optimized we expect an optimized frame for f. We
// can't say whether or not the top 3 frames (g1, g2 and g3) are
// optimized and inlined.
var frame4 = exec_state.frame(4);
if (isCurrentlyOptimized(f)) {
assertTrue(frame4.isOptimizedFrame());
assertFalse(frame4.isInlinedFrame());
}
// Indicate that all was processed.
listenerComplete = true;
}

32
test/mjsunit/debug-evaluate-locals-optimized.js
View File

@ -46,6 +46,11 @@ function arraySum(arr) {
return arr.reduce(function (a, b) { return a + b; }, 0);
}
function isCurrentlyOptimized(fun) {
// See runtime.cc.
return (%GetOptimizationStatus(fun) & 1) != 0;
}
function listener(event, exec_state, event_data, data) {
try {
if (event == Debug.DebugEvent.Break)
@ -138,23 +143,22 @@ function listener(event, exec_state, event_data, data) {
assertFalse(frame.isConstructCall());
}
// When function f is optimized (1 means YES, see runtime.cc) we
// expect an optimized frame for f with g1, g2 and g3 inlined.
if (%GetOptimizationStatus(f) == 1) {
if (i == 1 || i == 2 || i == 3) {
assertTrue(frame.isOptimizedFrame());
assertTrue(frame.isInlinedFrame());
assertEquals(4 - i, frame.inlinedFrameIndex());
} else if (i == 4) {
assertTrue(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
} else {
assertFalse(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
}
if (i > 4) {
assertFalse(frame.isOptimizedFrame());
assertFalse(frame.isInlinedFrame());
}
}
// When function f is optimized we expect an optimized frame for f. We
// can't say whether or not the top 3 frames (g1, g2 and g3) are
// optimized and inlined.
var frame4 = exec_state.frame(4);
if (isCurrentlyOptimized(f)) {
assertTrue(frame4.isOptimizedFrame());
assertFalse(frame4.isInlinedFrame());
}
// Indicate that all was processed.
listenerComplete = true;
}