AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Make the inlining heuristic deterministic.

Browse Source 
Don't sort inline candidates by comparing Node pointers, where the order
depends on the allocation order and the concrete Zone memory layout at
runtime. Instead sort based on NodeId, which is deterministic.

R=mvstanton@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2336113002
Cr-Commit-Position: refs/heads/master@{#39371}
This commit is contained in:
bmeurer 2016-09-13 01:19:22 -07:00 committed by Commit bot
parent 086f566ed8
commit ae9a39b010
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/js-inlining-heuristic.cc
View File

@ -285,7 +285,7 @@ bool JSInliningHeuristic::CandidateCompare::operator()(
if (left.calls != right.calls) { if (left.calls != right.calls) {
return left.calls > right.calls; return left.calls > right.calls;
} }
return left.node < right.node; return left.node->id() > right.node->id();
} }
void JSInliningHeuristic::PrintCandidates() { void JSInliningHeuristic::PrintCandidates() {