From affd6dfcb5676347025dd8c8899e15fae1c56d53 Mon Sep 17 00:00:00 2001 From: "balazs.kilvady" Date: Tue, 8 Sep 2015 12:32:06 -0700 Subject: [PATCH] MIPS: Fix 'Optimize simulator.' For simulator optimization we modified Instruction::InstructionType() function so a simpler but less complete InstructionType() function used by default. This fix enables the full InstructionType checking to properly decode a dd-constant label as unsupported opcode, rather than aborting. BUG=chromium:528875 LOG=NO Review URL: https://codereview.chromium.org/1314673010 Cr-Commit-Position: refs/heads/master@{#30644} --- src/mips/disasm-mips.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mips/disasm-mips.cc b/src/mips/disasm-mips.cc index 6028e90b44..f24ec436f0 100644 --- a/src/mips/disasm-mips.cc +++ b/src/mips/disasm-mips.cc @@ -1606,7 +1606,7 @@ int Decoder::InstructionDecode(byte* instr_ptr) { out_buffer_pos_ += SNPrintF(out_buffer_ + out_buffer_pos_, "%08x ", instr->InstructionBits()); - switch (instr->InstructionType()) { + switch (instr->InstructionType(Instruction::EXTRA)) { case Instruction::kRegisterType: { DecodeTypeRegister(instr); break;