AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[gdbinit] Also look for OS::DebugBreak frames

Browse Source 
If such a frame is near the top of the stack frame, move to the frame
below instead, which is the caller of OS::DebugBreak.
Also, rename dcheck_stop_handler to v8_stop_handler since we handle more
than DCHECKs there.

R=leszeks@chromium.org

No-Try: true
Change-Id: Ib31c2dc8278ec779a00babfdc952453e66e5f110
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3366238
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78481}
This commit is contained in:
Clemens Backes 2022-01-04 14:39:33 +01:00 committed by V8 LUCI CQ
parent 406d65d3bc
commit b04d9eea02
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/gdbinit
View File

@ -161,16 +161,17 @@ end
set disable-randomization off
# Install a handler whenever the debugger stops due to a signal. It walks up the
# stack looking for V8_Dcheck and moves the frame to the one above it so it's
# immediately at the line of code that triggered the DCHECK.
# stack looking for V8_Dcheck / V8_Fatal / OS::DebugBreak frame and moves the
# frame to the one above it so it's immediately at the line of code that
# triggered the stop condition.
python
def dcheck_stop_handler(event):
def v8_stop_handler(event):
frame = gdb.selected_frame()
select_frame = None
message = None
count = 0
# limit stack scanning since they're usually shallow and otherwise stack
# overflows can be very slow.
# Limit stack scanning since the frames we look for are near the top anyway,
# and otherwise stack overflows can be very slow.
while frame is not None and count < 7:
count += 1
# If we are in a frame created by gdb (e.g. for `(gdb) call foo()`), gdb
@ -186,6 +187,8 @@ def dcheck_stop_handler(event):
break
if frame.name() is not None and frame.name().startswith('V8_Fatal'):
select_frame = frame.older()
if frame.name() == 'v8::base::OS::DebugBreak':
select_frame = frame.older()
frame = frame.older()
if select_frame is not None:
@ -194,7 +197,7 @@ def dcheck_stop_handler(event):
if message:
print('DCHECK error: {}'.format(message))
gdb.events.stop.connect(dcheck_stop_handler)
gdb.events.stop.connect(v8_stop_handler)
end
# Code imported from chromium/src/tools/gdb/gdbinit