From b0fa91965d76ee57dfc699169966fe5f9e1e845e Mon Sep 17 00:00:00 2001 From: Hannes Payer Date: Fri, 9 Mar 2018 12:05:53 +0000 Subject: [PATCH] Revert "[heap] Turn on --write-protect-code-memory." This reverts commit e816d2bad040bf1ee31b1723734bfa3ed1198f0c. Reason for revert: Original change's description: > [heap] Turn on --write-protect-code-memory. > > Bug: chromium:774108 > Change-Id: Ifcf9939f29c9a3dc14ed686dc14608860ff32678 > Reviewed-on: https://chromium-review.googlesource.com/950902 > Reviewed-by: Michael Starzinger > Reviewed-by: Michael Hablich > Commit-Queue: Hannes Payer > Cr-Commit-Position: refs/heads/master@{#51766} TBR=mstarzinger@chromium.org,hpayer@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:774108 Change-Id: Icf6da14ec795cf89d2c4085ff7f9afb892184c12 Reviewed-on: https://chromium-review.googlesource.com/955692 Reviewed-by: Hannes Payer Commit-Queue: Hannes Payer Cr-Commit-Position: refs/heads/master@{#51840} --- src/flag-definitions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index d0fc8ec5f1..444792fa3f 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -522,7 +522,7 @@ DEFINE_DEBUG_BOOL(wasm_trace_native_heap, false, "trace wasm native heap events") DEFINE_BOOL(wasm_jit_to_native, true, "JIT wasm code to native (not JS GC) memory") -DEFINE_BOOL(wasm_write_protect_code_memory, true, +DEFINE_BOOL(wasm_write_protect_code_memory, false, "write protect code memory on the wasm native heap") DEFINE_IMPLICATION(future, wasm_jit_to_native) DEFINE_BOOL(wasm_trace_serialization, false,