[respect] Stop using "blacklist" in several python tools
Bug: v8:10619 Change-Id: I644c3421085b029aaf9b4de3b262ca8a4734539e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2292916 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#68812}
This commit is contained in:
parent
0a7d77ecba
commit
b212db2d9d
@ -48,7 +48,7 @@ NO_HARNESS_PATTERN = re.compile(r"^// NO HARNESS$", flags=re.MULTILINE)
|
||||
|
||||
# Flags known to misbehave when combining arbitrary mjsunit tests. Can also
|
||||
# be compiled regular expressions.
|
||||
COMBINE_TESTS_FLAGS_BLACKLIST = [
|
||||
MISBEHAVING_COMBINED_TESTS_FLAGS= [
|
||||
'--check-handle-count',
|
||||
'--enable-tracing',
|
||||
re.compile('--experimental.*'),
|
||||
@ -206,7 +206,7 @@ class CombinedTest(testcase.D8TestCase):
|
||||
"""In addition to standard set of shell flags it appends:
|
||||
--disable-abortjs: %AbortJS can abort the test even inside
|
||||
trycatch-wrapper, so we disable it.
|
||||
--es-staging: We blacklist all harmony flags due to false positives,
|
||||
--es-staging: We skip all harmony flags due to false positives,
|
||||
but always pass the staging flag to cover the mature features.
|
||||
--omit-quit: Calling quit() in JS would otherwise early terminate.
|
||||
--quiet-load: suppress any stdout from load() function used by
|
||||
@ -247,8 +247,8 @@ class CombinedTest(testcase.D8TestCase):
|
||||
elif flag1.startswith('-'):
|
||||
yield flag1
|
||||
|
||||
def _is_flag_blacklisted(self, flag):
|
||||
for item in COMBINE_TESTS_FLAGS_BLACKLIST:
|
||||
def _is_flag_blocked(self, flag):
|
||||
for item in MISBEHAVING_COMBINED_TESTS_FLAGS:
|
||||
if isinstance(item, basestring):
|
||||
if item == flag:
|
||||
return True
|
||||
@ -267,7 +267,7 @@ class CombinedTest(testcase.D8TestCase):
|
||||
unique_flags = OrderedDict((flag, True) for flag in merged_flags).keys()
|
||||
return [
|
||||
flag for flag in unique_flags
|
||||
if not self._is_flag_blacklisted(flag)
|
||||
if not self._is_flag_blocked(flag)
|
||||
]
|
||||
|
||||
def _get_source_flags(self):
|
||||
|
@ -15,7 +15,7 @@ import subprocess
|
||||
import sys
|
||||
|
||||
|
||||
BLACKLIST = [
|
||||
SKIPLIST = [
|
||||
# Skip special d8 functions.
|
||||
"load", "os", "print", "read", "readline", "quit"
|
||||
]
|
||||
@ -120,7 +120,7 @@ def GenerateTests(options):
|
||||
|
||||
os.makedirs(options.outdir)
|
||||
for obj_name in objects:
|
||||
if obj_name in BLACKLIST: continue
|
||||
if obj_name in SKIPLIST: continue
|
||||
obj = objects[obj_name]
|
||||
VisitObject(obj, "", options)
|
||||
|
||||
|
@ -69,7 +69,7 @@ EXCLUSIONS = [
|
||||
|
||||
# Executables found in the build output for which no coverage is generated.
|
||||
# Exclude them from the coverage data file.
|
||||
EXE_BLACKLIST = [
|
||||
EXE_EXCLUSIONS = [
|
||||
'generate-bytecode-expectations',
|
||||
'hello-world',
|
||||
'mksnapshot',
|
||||
@ -109,7 +109,7 @@ def executables(build_dir):
|
||||
file_path = os.path.join(build_dir, f)
|
||||
if (os.path.isfile(file_path) and
|
||||
os.access(file_path, os.X_OK) and
|
||||
f not in EXE_BLACKLIST):
|
||||
f not in EXE_EXCLUSIONS):
|
||||
yield file_path
|
||||
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user