From b234e2e747a369409fe39fc2844d69079fad5263 Mon Sep 17 00:00:00 2001 From: Andrew Grieve Date: Wed, 11 Jan 2023 16:48:01 -0500 Subject: [PATCH] Remove GN visibility restriction for run_mksnapshot_default This will allow embedders to build the snapshot file without building all of v8. Bug: chromium:1402705 Change-Id: I5049c18a803fd664e10036adcaef93503f013304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4157273 Reviewed-by: Adam Klein Commit-Queue: Andrew Grieve Cr-Commit-Position: refs/heads/main@{#85268} --- BUILD.gn | 6 ------ 1 file changed, 6 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index fb90dc06fa..5e7db43f76 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -2177,12 +2177,6 @@ template("run_mksnapshot") { suffix = "_$name" } action("run_mksnapshot_" + name) { - # Only targets in this file and running mkgrokdump can depend on this. - visibility = [ - ":*", - "tools/debug_helper:run_mkgrokdump", - ] - deps = [ ":mksnapshot($v8_snapshot_toolchain)" ] script = "tools/run.py"