AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

No need to start Ticker for Crankshaft

Browse Source 
Crankshaft doesn't depend on the sampler thread any more. No
need to start the that thread for Crankshaft.

BUG=v8:2609

Review URL: https://codereview.chromium.org/13526003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yurys@chromium.org 2013-04-08 15:09:03 +00:00
parent 90a587088b
commit b293d4d4a2
4 changed files with 2 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/isolate.cc
View File

@ -1808,7 +1808,8 @@ void Isolate::Deinit() {
if (FLAG_hydrogen_stats) GetHStatistics()->Print();
// We must stop the logger before we tear down other components.
logger_->EnsureTickerStopped();
Sampler* sampler = logger_->sampler();
if (sampler && sampler->IsActive()) sampler->Stop();
delete deoptimizer_data_;
deoptimizer_data_ = NULL;

16
src/log.cc
View File

@ -1560,11 +1560,6 @@ void Logger::LogFailure() {
}
bool Logger::IsProfilerSamplerActive() {
return ticker_->IsActive();
}
class EnumerateOptimizedFunctionsVisitor: public OptimizedFunctionVisitor {
public:
EnumerateOptimizedFunctionsVisitor(Handle<SharedFunctionInfo>* sfis,
@ -1937,17 +1932,6 @@ Sampler* Logger::sampler() {
}
void Logger::EnsureTickerStarted() {
ASSERT(ticker_ != NULL);
if (!ticker_->IsActive()) ticker_->Start();
}
void Logger::EnsureTickerStopped() {
if (ticker_ != NULL && ticker_->IsActive()) ticker_->Stop();
}
FILE* Logger::TearDown() {
if (!is_initialized_) return NULL;
is_initialized_ = false;

6
src/log.h
View File

@ -168,9 +168,6 @@ class Logger {
void SetCodeEventHandler(uint32_t options,
JitCodeEventHandler event_handler);
void EnsureTickerStarted();
void EnsureTickerStopped();
Sampler* sampler();
// Frees resources acquired in SetUp.
@ -448,9 +445,6 @@ class Logger {
void UncheckedIntEvent(const char* name, int value);
void UncheckedIntPtrTEvent(const char* name, intptr_t value);
// Returns whether profiler's sampler is active.
bool IsProfilerSamplerActive();
Isolate* isolate_;
// The sampler used by the profiler and the sliding state window.

3
src/runtime-profiler.cc
View File

@ -389,9 +389,6 @@ void RuntimeProfiler::SetUp() {
if (!FLAG_watch_ic_patching) {
ClearSampleBuffer();
}
// If the ticker hasn't already started, make sure to do so to get
// the ticks for the runtime profiler.
if (IsEnabled()) isolate_->logger()->EnsureTickerStarted();
}