AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Drop deprecated method for backing store from AccessBuilder.

Browse Source 
R=bmeurer@chromium.org
TEST=cctest/test-simplified-lowering/RunLoadStoreArrayBuffer

Review URL: https://codereview.chromium.org/614703002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24282 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
mstarzinger@chromium.org 2014-09-29 11:35:01 +00:00
parent df2e4f8e9b
commit b2aaac9404
3 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/access-builder.cc
View File

@ -57,13 +57,6 @@ ElementAccess AccessBuilder::ForFixedArrayElement() {
}
// static
ElementAccess AccessBuilder::ForBackingStoreElement(MachineType rep) {
return {kUntaggedBase, kNonHeapObjectHeaderSize - kHeapObjectTag, Type::Any(),
rep};
}
// static
ElementAccess AccessBuilder::ForTypedArrayElement(ExternalArrayType type,
bool is_external) {

3
src/compiler/access-builder.h
View File

@ -37,9 +37,6 @@ class AccessBuilder FINAL : public AllStatic {
// Provides access to FixedArray elements.
static ElementAccess ForFixedArrayElement();
// TODO(mstarzinger): Raw access only for testing, drop me.
static ElementAccess ForBackingStoreElement(MachineType rep);
// Provides access to Fixed{type}TypedArray and External{type}Array elements.
static ElementAccess ForTypedArrayElement(ExternalArrayType type,
bool is_external);

2
test/cctest/compiler/test-simplified-lowering.cc
View File

@ -235,7 +235,7 @@ TEST(RunLoadStoreArrayBuffer) {
const int index = 12;
const int array_length = 2 * index;
ElementAccess buffer_access =
AccessBuilder::ForBackingStoreElement(kMachInt8);
AccessBuilder::ForTypedArrayElement(v8::kExternalInt8Array, true);
Node* backing_store = t.LoadField(
AccessBuilder::ForJSArrayBufferBackingStore(), t.Parameter(0));
Node* load =