AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Attempt to fix MSVC failure in test-debug/BreakPointJSBuiltin

Browse Source 
TBR=bmeurer@chromium.org

Bug: v8:178
Change-Id: Idfa86749f3ee49c9f3b2a7fc7c0d7d3285e45c20
Reviewed-on: https://chromium-review.googlesource.com/956066
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51824}
This commit is contained in:
Yang Guo 2018-03-08 19:41:28 +01:00 committed by Commit Bot
parent bf021c3c1b
commit b342e61122
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/debug/debug.cc
View File

@ -1179,7 +1179,7 @@ void Debug::InstallDebugBreakTrampoline() {
if (!shared->HasDebugInfo()) continue;
if (!shared->GetDebugInfo()->CanBreakAtEntry()) continue;
if (!fun->is_compiled()) {
needs_compile.push_back(handle(fun));
needs_compile.emplace_back(fun, isolate_);
} else {
fun->set_code(*trampoline);
}
@ -1189,7 +1189,7 @@ void Debug::InstallDebugBreakTrampoline() {
}
// By overwriting the function code with DebugBreakTrampoline, which tailcalls
// to shared code, we bypass CompileLazy. Perform CompileLazy here instead.
for (Handle<JSFunction> fun : needs_compile) {
for (const auto& fun : needs_compile) {
Compiler::Compile(fun, Compiler::CLEAR_EXCEPTION);
fun->set_code(*trampoline);
}

2
test/cctest/cctest.status
View File

@ -234,8 +234,6 @@
##############################################################################
['system == windows', {
# BUG(178). Fails on windows.
'test-debug/BreakPointJSBuiltin': [SKIP],
# BUG(3331). Fails on windows.
'test-heap/NoWeakHashTableLeakWithIncrementalMarking': [SKIP],