diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h index d06e3184f8..c6a5111b05 100644 --- a/src/hydrogen-instructions.h +++ b/src/hydrogen-instructions.h @@ -5593,6 +5593,7 @@ class HStoreNamedField: public HTemplateInstruction<2> { SetGVNFlag(kChangesBackingStoreFields); SetGVNFlag(kDependsOnNewSpacePromotion); } + SetFlag(kDeoptimizeOnUndefined); } DECLARE_CONCRETE_INSTRUCTION(StoreNamedField) diff --git a/test/mjsunit/regress/regress-copy-hole-to-field.js b/test/mjsunit/regress/regress-copy-hole-to-field.js new file mode 100644 index 0000000000..fa3db92928 --- /dev/null +++ b/test/mjsunit/regress/regress-copy-hole-to-field.js @@ -0,0 +1,57 @@ +// Copyright 2013 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Flags: --allow-natives-syntax + +// Copy a hole from HOLEY_DOUBLE to double field. +var a = [1.5,,1.7]; +var o = {a:1.8}; + +function f1(o,a,i) { + o.a = a[i]; +} + +f1(o,a,0); +f1(o,a,0); +assertEquals(1.5, o.a); +%OptimizeFunctionOnNextCall(f1); +f1(o,a,1); +assertEquals(undefined, o.a); + +// Copy a hole from HOLEY_SMI to smi field. +var a = [1,,3]; +var o = {ab:5}; + +function f2(o,a,i) { + o.ab = a[i]; +} + +f2(o,a,0); +f2(o,a,0); +%OptimizeFunctionOnNextCall(f2); +f2(o,a,1); +assertEquals(undefined, o.ab);