AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove the unused hydrogen_track_positions flag.

Browse Source 
Change-Id: Ife88feb55f12c592b1c3b4435cd584333953ef6b
Reviewed-on: https://chromium-review.googlesource.com/593619
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47061}
This commit is contained in:
Jaroslav Sevcik 2017-07-31 13:54:02 +02:00 committed by Commit Bot
parent f19b889be8
commit b4b32df0b4
3 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flag-definitions.h
View File

@ -1177,12 +1177,8 @@ DEFINE_BOOL(redirect_code_traces, false,
DEFINE_STRING(redirect_code_traces_to, NULL,
"output deopt information and disassembly into the given file")
DEFINE_BOOL(hydrogen_track_positions, false,
"track source code positions when building IR")
DEFINE_BOOL(print_opt_source, false,
"print source code of optimized and inlined functions")
DEFINE_IMPLICATION(hydrogen_track_positions, print_opt_source)
//
// Disassembler only flags
@ -1231,7 +1227,6 @@ DEFINE_BOOL(sodium, false,
DEFINE_IMPLICATION(sodium, print_code_stubs)
DEFINE_IMPLICATION(sodium, print_code)
DEFINE_IMPLICATION(sodium, print_opt_code)
DEFINE_IMPLICATION(sodium, hydrogen_track_positions)
DEFINE_IMPLICATION(sodium, code_comments)
DEFINE_BOOL(print_all_code, false, "enable all flags related to printing code")

13
src/objects.cc
View File

@ -14297,15 +14297,10 @@ void Code::PrintDeoptLocation(FILE* out, Address pc) {
Deoptimizer::DeoptInfo info = Deoptimizer::GetDeoptInfo(this, pc);
class SourcePosition pos = info.position;
if (info.deopt_reason != DeoptimizeReason::kNoReason || pos.IsKnown()) {
if (FLAG_hydrogen_track_positions) {
PrintF(out, " ;;; deoptimize at %d_%d: %s\n", pos.InliningId(),
pos.ScriptOffset(), DeoptimizeReasonToString(info.deopt_reason));
} else {
PrintF(out, " ;;; deoptimize at ");
OFStream outstr(out);
pos.Print(outstr, this);
PrintF(out, ", %s\n", DeoptimizeReasonToString(info.deopt_reason));
}
PrintF(out, " ;;; deoptimize at ");
OFStream outstr(out);
pos.Print(outstr, this);
PrintF(out, ", %s\n", DeoptimizeReasonToString(info.deopt_reason));
}
}

1
test/cctest/test-cpu-profiler.cc
View File

@ -1903,7 +1903,6 @@ TEST(CollectDeoptEvents) {
TEST(SourceLocation) {
i::FLAG_always_opt = true;
i::FLAG_hydrogen_track_positions = true;
LocalContext env;
v8::HandleScope scope(CcTest::isolate());