AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[arm64] Fixed unnecessary environment assignment to LSmiTag instruction.

Browse Source 
BUG=chromium:490021
LOG=N

Review URL: https://codereview.chromium.org/1235563002

Cr-Commit-Position: refs/heads/master@{#29567}
This commit is contained in:
ishell 2015-07-10 04:36:03 -07:00 committed by Commit bot
parent 3c7d5820b1
commit b625d4d8cc
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/arm64/lithium-arm64.cc
View File

@ -1203,7 +1203,7 @@ LInstruction* LChunkBuilder::DoChange(HChange* instr) {
} else if (to.IsSmi()) {
LOperand* value = UseRegisterAtStart(val);
LInstruction* result = DefineAsRegister(new(zone()) LSmiTag(value));
if (val->CheckFlag(HInstruction::kUint32)) {
if (instr->CheckFlag(HValue::kCanOverflow)) {
result = AssignEnvironment(result);
}
return result;

15
test/mjsunit/regress/regress-crbug-490021.js Normal file
View File

@ -0,0 +1,15 @@
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
var global = new Object(3);
function f() {
global[0] = global[0] >>> 15.5;
}
f();
f();
%OptimizeFunctionOnNextCall(f);
f();