AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Take Symbol-keyed properties into account in Object.freeze and friends

Browse Source 
R=rossberg@chromium.org
BUG=chromium:539875
LOG=y

Review URL: https://codereview.chromium.org/1393373005

Cr-Commit-Position: refs/heads/master@{#31303}
This commit is contained in:
adamk 2015-10-15 06:32:44 -07:00 committed by Commit bot
parent 2aba89e336
commit b646cb3e50
2 changed files with 41 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/js/v8natives.js
View File

@ -1147,7 +1147,7 @@ function ObjectSealJS(obj) {
if (isProxy) {
ProxyFix(obj);
}
var names = ObjectGetOwnPropertyNames(obj);
var names = OwnPropertyKeys(obj);
for (var i = 0; i < names.length; i++) {
var name = names[i];
var desc = GetOwnPropertyJS(obj, name);
@ -1177,7 +1177,7 @@ function ObjectFreezeJS(obj) {
if (isProxy) {
ProxyFix(obj);
}
var names = ObjectGetOwnPropertyNames(obj);
var names = OwnPropertyKeys(obj);
for (var i = 0; i < names.length; i++) {
var name = names[i];
var desc = GetOwnPropertyJS(obj, name);
@ -1217,7 +1217,7 @@ function ObjectIsSealed(obj) {
if (%IsExtensible(obj)) {
return false;
}
var names = ObjectGetOwnPropertyNames(obj);
var names = OwnPropertyKeys(obj);
for (var i = 0; i < names.length; i++) {
var name = names[i];
var desc = GetOwnPropertyJS(obj, name);
@ -1238,7 +1238,7 @@ function ObjectIsFrozen(obj) {
if (%IsExtensible(obj)) {
return false;
}
var names = ObjectGetOwnPropertyNames(obj);
var names = OwnPropertyKeys(obj);
for (var i = 0; i < names.length; i++) {
var name = names[i];
var desc = GetOwnPropertyJS(obj, name);

37
test/mjsunit/regress/regress-539875.js Normal file
View File

@ -0,0 +1,37 @@
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
(function testSeal() {
var sloppy = arguments;
var sym = Symbol();
sloppy[sym] = 123;
Object.seal(sloppy);
assertTrue(Object.isSealed(sloppy));
var desc = Object.getOwnPropertyDescriptor(sloppy, sym);
assertEquals(123, desc.value);
assertFalse(desc.configurable);
assertTrue(desc.writable);
})();
(function testFreeze() {
var sloppy = arguments;
var sym = Symbol();
sloppy[sym] = 123;
Object.freeze(sloppy);
assertTrue(Object.isFrozen(sloppy));
var desc = Object.getOwnPropertyDescriptor(sloppy, sym);
assertEquals(123, desc.value);
assertFalse(desc.configurable);
assertFalse(desc.writable);
})();
(function testIsFrozenAndIsSealed() {
var sym = Symbol();
var obj = { [sym]: 123 };
Object.preventExtensions(obj);
assertFalse(Object.isFrozen(obj));
assertFalse(Object.isSealed(obj));
})();