AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Drop some obsolete code modification scopes.

Browse Source 
R=clemensh@chromium.org
BUG=v8:6792,v8:7549

Change-Id: I1d153dcff729ed4c0863ae339ac7915efff3c33c
Reviewed-on: https://chromium-review.googlesource.com/968484
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52035}
This commit is contained in:
Michael Starzinger 2018-03-19 15:09:11 +01:00 committed by Commit Bot
parent 2ba5b33300
commit b6ecf53b05
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wasm/module-compiler.cc
View File

@ -568,8 +568,6 @@ const wasm::WasmCode* LazyCompilationOrchestrator::CompileFunction(
CStrVector(func_name.c_str()), func_index,
CEntryStub(isolate, 1).GetCode());
unit.ExecuteCompilation();
// TODO(6792): No longer needed once WebAssembly code is off heap.
CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
wasm::WasmCode* wasm_code = unit.FinishCompilation(&thrower);
// If there is a pending error, something really went wrong. The module was

3
src/wasm/wasm-module.cc
View File

@ -61,9 +61,6 @@ void UnpackAndRegisterProtectedInstructions(
RegisterHandlerData(base, size, code->protected_instructions().size(),
code->protected_instructions().data());
// TODO(6792): No longer needed once WebAssembly code is off heap.
CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
// TODO(eholk): if index is negative, fail.
CHECK_LE(0, index);
code->set_trap_handler_index(static_cast<size_t>(index));