From b7d5b94f5bbb22f86f3356c9d2cb6de6c7376f10 Mon Sep 17 00:00:00 2001 From: Frank Tang Date: Fri, 18 Jun 2021 21:29:52 +0000 Subject: [PATCH] Revert "[intl] Ship "best fit" LocaleMatcher for m93" This reverts commit f8a40f6d2792db14017b5a13fc55f6c2366d7ee6. Reason for revert: Performance regression Original change's description: > [intl] Ship "best fit" LocaleMatcher for m93 > > LGTM1 Mike West mkwst@chromium.org > LGTM2 Chris Harrelson chrishtr@chromium.org > LGTM3 Yoav Weiss yoavweiss@chromium.org > > Design Doc: > https://docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk > R2T: https://groups.google.com/a/chromium.org/g/blink-dev/c/W7TcX1tSHDI/m/1AthUhEWBAAJ > I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/TpAvyXwHM_c/m/QXJKbClfAwAJ > Stage in m92 Canary 92 92.0.4500.0 Dev 92 92.0.4503.3 Beta 92 92.0.4515.40 > https://chromiumdash.appspot.com/commit/eb6482784ca71d3b22db449fd941bfa9872d244a > > > Bug: v8:7051, v8:11868, v8:11869 > Change-Id: Id1ae20234b764e6f6def83af651daf70056d0725 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2950559 > Reviewed-by: Shu-yu Guo > Commit-Queue: Frank Tang > Cr-Commit-Position: refs/heads/master@{#75194} Bug: v8:7051, v8:11868, v8:11869 Change-Id: I1c5d2c2201f7724eb7db67f2c5268b787d6ca8eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973649 Bot-Commit: Rubber Stamper Reviewed-by: Frank Tang Cr-Commit-Position: refs/heads/master@{#75263} --- src/flags/flag-definitions.h | 8 ++++---- test/test262/test262.status | 6 ------ 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index b984c86891..84a06c6213 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -292,6 +292,7 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features") #ifdef V8_INTL_SUPPORT #define HARMONY_STAGED(V) \ HARMONY_STAGED_BASE(V) \ + V(harmony_intl_best_fit_matcher, "Intl BestFitMatcher") \ V(harmony_intl_displaynames_v2, "Intl.DisplayNames v2") \ V(harmony_intl_locale_info, "Intl locale info") \ V(harmony_intl_more_timezone, \ @@ -311,10 +312,9 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features") V(harmony_error_cause, "harmony error cause property") #ifdef V8_INTL_SUPPORT -#define HARMONY_SHIPPING(V) \ - HARMONY_SHIPPING_BASE(V) \ - V(harmony_intl_best_fit_matcher, "Intl BestFitMatcher") \ - V(harmony_intl_dateformat_day_period, \ +#define HARMONY_SHIPPING(V) \ + HARMONY_SHIPPING_BASE(V) \ + V(harmony_intl_dateformat_day_period, \ "Add dayPeriod option to DateTimeFormat") #else #define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V) diff --git a/test/test262/test262.status b/test/test262/test262.status index c9752e3c87..17b6e480e3 100644 --- a/test/test262/test262.status +++ b/test/test262/test262.status @@ -532,12 +532,6 @@ # http://crbug/v8/10447 'intl402/Intl/getCanonicalLocales/unicode-ext-canonicalize-yes-to-true': [FAIL], - # http://crbug/v8/11868 and https://github.com/tc39/test262/pull/3008 - 'intl402/Segmenter/constructor/supportedLocalesOf/locales-specific': [FAIL], - - # http://crbug/v8/11869 and https://github.com/tc39/test262/pull/3008 - 'intl402/supportedLocalesOf-consistent-with-resolvedOptions': [FAIL], - # https://bugs.chromium.org/p/v8/issues/detail?id=9818 'built-ins/AsyncFunction/proto-from-ctor-realm': [FAIL],