AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[heap] Update young nodes of traced handles"

Browse Source 
This reverts commit 31edec6406.

Reason for revert: Crashes on GPU bots

Original change's description:
> [heap] Update young nodes of traced handles
>
> Fix regressions caused by
>   https://crrev.com/c/3966952
>
> Update and clear the list of young nodes which would otherwise be
> repeatedly processed during Scavenge and full GCs.
>
> Bug: v8:13372, chromium:1378097
> Change-Id: I1b302f75f970385e9e0259fa4b1719d9262c1f2a
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3981273
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#83922}

Bug: v8:13372, chromium:1378097
Change-Id: Id2b4f565e2a92d01a54942630627cb8aebec06d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3981493
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#83928}
This commit is contained in:
Michael Lippautz 2022-10-26 10:58:33 +00:00 committed by V8 LUCI CQ
parent 20b395a8ef
commit b835d86cd4
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/heap/mark-compact.cc
View File

@ -989,9 +989,7 @@ void MarkCompactCollector::Finish() {
TRACE_GC(heap()->tracer(), GCTracer::Scope::MC_FINISH);
auto* isolate = heap()->isolate();
isolate->global_handles()->ClearListOfYoungNodes();
isolate->traced_handles()->ClearListOfYoungNodes();
heap()->isolate()->global_handles()->ClearListOfYoungNodes();
SweepArrayBufferExtensions();
@ -1024,7 +1022,7 @@ void MarkCompactCollector::Finish() {
if (have_code_to_deoptimize_) {
// Some code objects were marked for deoptimization during the GC.
Deoptimizer::DeoptimizeMarkedCode(isolate);
Deoptimizer::DeoptimizeMarkedCode(isolate());
have_code_to_deoptimize_ = false;
}
}
@ -5860,9 +5858,7 @@ void MinorMarkCompactCollector::CollectGarbage() {
SweepArrayBufferExtensions();
auto* isolate = heap()->isolate();
isolate->global_handles()->UpdateListOfYoungNodes();
isolate->traced_handles()->UpdateListOfYoungNodes();
heap()->isolate()->global_handles()->UpdateListOfYoungNodes();
}
void MinorMarkCompactCollector::MakeIterable(

1
src/heap/scavenger.cc
View File

@ -498,7 +498,6 @@ void ScavengerCollector::CollectGarbage() {
}
isolate_->global_handles()->UpdateListOfYoungNodes();
isolate_->traced_handles()->ClearListOfYoungNodes();
// Update how much has survived scavenge.
heap_->IncrementYoungSurvivorsCounter(heap_->SurvivedYoungObjectSize());