AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[infra] Band-aid presubmit for new cpplint.py messages

Browse Source 
Bug: v8:12743
Change-Id: I4a36c0b794759d47eb9436714dfd2417fc45dcd2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3558327
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79661}
This commit is contained in:
Shu-yu Guo 2022-03-29 14:50:34 -07:00 committed by V8 LUCI CQ
parent 2637f50227
commit b8b9013541
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/v8_presubmit.py
View File

@ -73,7 +73,7 @@ LINT_RULES = """
-whitespace/comments -whitespace/comments
""".split() """.split()
LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]|^Done processing') LINT_OUTPUT_PATTERN = re.compile(r'^.+[:(]\d+[:)]')
FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n") FLAGS_LINE = re.compile("//\s*Flags:.*--([A-z0-9-])+_[A-z0-9].*\n")
ASSERT_OPTIMIZED_PATTERN = re.compile("assertOptimized") ASSERT_OPTIMIZED_PATTERN = re.compile("assertOptimized")
FLAGS_ENABLE_OPT = re.compile("//\s*Flags:.*--opt[^-].*\n") FLAGS_ENABLE_OPT = re.compile("//\s*Flags:.*--opt[^-].*\n")
@ -95,10 +95,14 @@ def CppLintWorker(command):
print("Failed to process %s" % command.pop()) print("Failed to process %s" % command.pop())
return 1 return 1
break break
m = LINT_OUTPUT_PATTERN.match(out_line) if out_line.strip() == 'Total errors found: 0':
if m: out_lines += "Done processing %s\n" % command.pop()
out_lines += out_line
error_count += 1 error_count += 1
else:
m = LINT_OUTPUT_PATTERN.match(out_line)
if m:
out_lines += out_line
error_count += 1
sys.stdout.write(out_lines) sys.stdout.write(out_lines)
return error_count return error_count
except KeyboardInterrupt: except KeyboardInterrupt: