[build] Add more v8 build options and fix existing ones.

New options: v8_enable_trace_maps, v8_enable_v8_checks.
Renamed options for consistency: v8_object_print to v8_enable_object_print.
Fixed options: v8_enable_verify_heap, v8_enable_object_print.

BUG=

Review-Url: https://codereview.chromium.org/2625393003
Cr-Commit-Position: refs/heads/master@{#42338}
This commit is contained in:
ishell 2017-01-13 09:28:51 -08:00 committed by Commit bot
parent 57a87a5270
commit b908229500

View File

@ -21,7 +21,7 @@ declare_args() {
v8_android_log_stdout = false v8_android_log_stdout = false
# Sets -DVERIFY_HEAP. # Sets -DVERIFY_HEAP.
v8_enable_verify_heap = false v8_enable_verify_heap = ""
# Sets -DVERIFY_PREDICTABLE # Sets -DVERIFY_PREDICTABLE
v8_enable_verify_predictable = false v8_enable_verify_predictable = false
@ -52,7 +52,13 @@ declare_args() {
v8_interpreted_regexp = false v8_interpreted_regexp = false
# Sets -dOBJECT_PRINT. # Sets -dOBJECT_PRINT.
v8_object_print = "" v8_enable_object_print = ""
# Sets -dTRACE_MAPS.
v8_enable_trace_maps = ""
# Sets -dV8_ENABLE_CHECKS.
v8_enable_v8_checks = ""
# With post mortem support enabled, metadata is embedded into libv8 that # With post mortem support enabled, metadata is embedded into libv8 that
# describes various parameters of the VM for use by debuggers. See # describes various parameters of the VM for use by debuggers. See
@ -90,11 +96,20 @@ if (v8_enable_gdbjit == "") {
} }
# Derived defaults. # Derived defaults.
if (v8_object_print == "") { if (v8_enable_verify_heap == "") {
v8_object_print = is_debug && !v8_optimized_debug v8_enable_verify_heap = is_debug
}
if (v8_enable_object_print == "") {
v8_enable_object_print = is_debug
} }
if (v8_enable_disassembler == "") { if (v8_enable_disassembler == "") {
v8_enable_disassembler = is_debug && !v8_optimized_debug v8_enable_disassembler = is_debug
}
if (v8_enable_trace_maps == "") {
v8_enable_trace_maps = is_debug
}
if (v8_enable_v8_checks == "") {
v8_enable_v8_checks = is_debug
} }
# Specifies if the target build is a simulator build. Comparing target cpu # Specifies if the target build is a simulator build. Comparing target cpu
@ -180,7 +195,7 @@ config("features") {
if (v8_enable_gdbjit) { if (v8_enable_gdbjit) {
defines += [ "ENABLE_GDB_JIT_INTERFACE" ] defines += [ "ENABLE_GDB_JIT_INTERFACE" ]
} }
if (v8_object_print) { if (v8_enable_object_print) {
defines += [ "OBJECT_PRINT" ] defines += [ "OBJECT_PRINT" ]
} }
if (v8_enable_verify_heap) { if (v8_enable_verify_heap) {
@ -189,6 +204,12 @@ config("features") {
if (v8_enable_verify_predictable) { if (v8_enable_verify_predictable) {
defines += [ "VERIFY_PREDICTABLE" ] defines += [ "VERIFY_PREDICTABLE" ]
} }
if (v8_enable_trace_maps) {
defines += [ "TRACE_MAPS" ]
}
if (v8_enable_v8_checks) {
defines += [ "V8_ENABLE_CHECKS" ]
}
if (v8_interpreted_regexp) { if (v8_interpreted_regexp) {
defines += [ "V8_INTERPRETED_REGEXP" ] defines += [ "V8_INTERPRETED_REGEXP" ]
} }
@ -352,15 +373,7 @@ config("toolchain") {
ldflags += [ "-rdynamic" ] ldflags += [ "-rdynamic" ]
} }
# TODO(jochen): Add support for different debug optimization levels. defines += [ "DEBUG" ]
defines += [
"ENABLE_DISASSEMBLER",
"V8_ENABLE_CHECKS",
"OBJECT_PRINT",
"VERIFY_HEAP",
"DEBUG",
"TRACE_MAPS",
]
if (v8_enable_slow_dchecks) { if (v8_enable_slow_dchecks) {
defines += [ "ENABLE_SLOW_DCHECKS" ] defines += [ "ENABLE_SLOW_DCHECKS" ]
} }