AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Coverage] Add sancov_formatter unittest for split.

Browse Source 
Unittest for feature added in:
https://codereview.chromium.org/1808663002/

BUG=chromium:568949
LOG=n
NOTRY=true

Review URL: https://codereview.chromium.org/1810043004

Cr-Commit-Position: refs/heads/master@{#34923}
This commit is contained in:
machenbach 2016-03-21 02:23:21 -07:00 committed by Commit bot
parent b7aa4c3ab3
commit b954b18719
2 changed files with 65 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/sanitizers/sancov_formatter.py
View File

@ -401,7 +401,7 @@ def split(options):
json.dump(new_data, f, sort_keys=True)
def main():
def main(args=None):
parser = argparse.ArgumentParser()
parser.add_argument('--coverage-dir',
help='Path to the sancov output files.')
@ -414,7 +414,7 @@ def main():
parser.add_argument('action', choices=['all', 'merge', 'split'],
help='Action to perform.')
options = parser.parse_args()
options = parser.parse_args(args)
if options.action.lower() == 'all':
if not options.json_output:
print '--json-output is required'

63
tools/sanitizers/sancov_formatter_test.py
View File

@ -8,8 +8,11 @@
import copy
import coverage
import logging
import json
import os
import shutil
import sys
import tempfile
import unittest
@ -128,6 +131,44 @@ EXPECTED_COVERED_LINES_DATA = {
}
#------------------------------------------------------------------------------
# Data for test_split.
EXPECTED_SPLIT_FILES = [
(
os.path.join('src', 'baz', 'bar.h.json'),
{
'version': 1,
'tests': ['cctest', 'd8', 'unittests'],
'files': {
'src/baz/bar.h': [[0, 0b0], [3, 0b11], [7, 0b11], [8, 0b0]],
},
},
),
(
os.path.join('src', 'baz.cc.json'),
{
'version': 1,
'tests': ['cctest', 'd8', 'unittests'],
'files': {
'src/baz.cc': [[1, 0b0], [2, 0b101]],
},
},
),
(
os.path.join('src', 'foo.cc.json'),
{
'version': 1,
'tests': ['cctest', 'd8', 'unittests'],
'files': {
'src/foo.cc': [[1, 0b1], [11, 0b10], [92, 0b100], [93, 0b0]],
},
},
),
]
class FormatterTests(unittest.TestCase):
@classmethod
def setUpClass(cls):
@ -157,3 +198,25 @@ class FormatterTests(unittest.TestCase):
sancov_formatter.merge_covered_line_results(
data, COVERED_LINE_RESULTS)
self.assertEquals(EXPECTED_COVERED_LINES_DATA, data)
def test_split(self):
_, json_input = tempfile.mkstemp(prefix='tmp_coverage_test_split')
with open(json_input, 'w') as f:
json.dump(EXPECTED_COVERED_LINES_DATA, f)
output_dir = tempfile.mkdtemp(prefix='tmp_coverage_test_split')
try:
sancov_formatter.main([
'split',
'--json-input', json_input,
'--output-dir', output_dir,
])
for file_name, expected_data in EXPECTED_SPLIT_FILES:
full_path = os.path.join(output_dir, file_name)
self.assertTrue(os.path.exists(full_path))
with open(full_path) as f:
self.assertEquals(expected_data, json.load(f))
finally:
os.remove(json_input)
shutil.rmtree(output_dir)