From b9d71d9339a6b6e31fb7283f21840d64415e446a Mon Sep 17 00:00:00 2001 From: Clemens Hammacher Date: Tue, 11 Sep 2018 15:45:12 +0200 Subject: [PATCH] [assembler][ia32] Replace UNREACHABLE by FATAL with message This improves the error message if we accidentally call this method on a CPU which does not support it. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: If67bf9e95ab0e71d832a833a70b6ba748b53296e Reviewed-on: https://chromium-review.googlesource.com/1219631 Reviewed-by: Michael Starzinger Commit-Queue: Clemens Hammacher Cr-Commit-Position: refs/heads/master@{#55796} --- src/ia32/macro-assembler-ia32.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc index 4cd4764653..aab9b3d3fc 100644 --- a/src/ia32/macro-assembler-ia32.cc +++ b/src/ia32/macro-assembler-ia32.cc @@ -1393,7 +1393,7 @@ void TurboAssembler::Psignb(XMMRegister dst, Operand src) { psignb(dst, src); return; } - UNREACHABLE(); + FATAL("no AVX or SSE3 support"); } void TurboAssembler::Psignw(XMMRegister dst, Operand src) { @@ -1407,7 +1407,7 @@ void TurboAssembler::Psignw(XMMRegister dst, Operand src) { psignw(dst, src); return; } - UNREACHABLE(); + FATAL("no AVX or SSE3 support"); } void TurboAssembler::Psignd(XMMRegister dst, Operand src) { @@ -1421,7 +1421,7 @@ void TurboAssembler::Psignd(XMMRegister dst, Operand src) { psignd(dst, src); return; } - UNREACHABLE(); + FATAL("no AVX or SSE3 support"); } void TurboAssembler::Pshufb(XMMRegister dst, Operand src) { @@ -1435,7 +1435,7 @@ void TurboAssembler::Pshufb(XMMRegister dst, Operand src) { pshufb(dst, src); return; } - UNREACHABLE(); + FATAL("no AVX or SSE3 support"); } void TurboAssembler::Pblendw(XMMRegister dst, Operand src, uint8_t imm8) { @@ -1449,7 +1449,7 @@ void TurboAssembler::Pblendw(XMMRegister dst, Operand src, uint8_t imm8) { pblendw(dst, src, imm8); return; } - UNREACHABLE(); + FATAL("no AVX or SSE4.1 support"); } void TurboAssembler::Palignr(XMMRegister dst, Operand src, uint8_t imm8) { @@ -1463,7 +1463,7 @@ void TurboAssembler::Palignr(XMMRegister dst, Operand src, uint8_t imm8) { palignr(dst, src, imm8); return; } - UNREACHABLE(); + FATAL("no AVX or SSE3 support"); } void TurboAssembler::Pextrb(Register dst, XMMRegister src, int8_t imm8) { @@ -1477,7 +1477,7 @@ void TurboAssembler::Pextrb(Register dst, XMMRegister src, int8_t imm8) { pextrb(dst, src, imm8); return; } - UNREACHABLE(); + FATAL("no AVX or SSE4.1 support"); } void TurboAssembler::Pextrw(Register dst, XMMRegister src, int8_t imm8) { @@ -1491,7 +1491,7 @@ void TurboAssembler::Pextrw(Register dst, XMMRegister src, int8_t imm8) { pextrw(dst, src, imm8); return; } - UNREACHABLE(); + FATAL("no AVX or SSE4.1 support"); } void TurboAssembler::Pextrd(Register dst, XMMRegister src, int8_t imm8) { @@ -1575,7 +1575,7 @@ void TurboAssembler::Popcnt(Register dst, Operand src) { popcnt(dst, src); return; } - UNREACHABLE(); + FATAL("no POPCNT support"); } void MacroAssembler::LoadWeakValue(Register in_out, Label* target_if_cleared) {