AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Removed PropertyDetails::IsProperty.

Browse Source 
This is just an intermediate step to remove IsRealProperty.

Review URL: https://chromiumcodereview.appspot.com/9325060

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
svenpanne@chromium.org 2012-02-06 12:11:40 +00:00
parent cb5164c0b0
commit ba6825012c
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/objects.cc
View File

@ -10360,7 +10360,7 @@ int JSObject::NumberOfLocalProperties(PropertyAttributes filter) {
int result = 0; int result = 0;
for (int i = 0; i < descs->number_of_descriptors(); i++) { for (int i = 0; i < descs->number_of_descriptors(); i++) {
PropertyDetails details(descs->GetDetails(i)); PropertyDetails details(descs->GetDetails(i));
if (details.IsProperty() && (details.attributes() & filter) == 0) { if (descs->IsProperty(i) && (details.attributes() & filter) == 0) {
result++; result++;
} }
} }

4
src/property-details.h
View File

@ -119,10 +119,6 @@ class PropertyDetails BASE_EMBEDDED {
PropertyType type() { return TypeField::decode(value_); } PropertyType type() { return TypeField::decode(value_); }
bool IsProperty() {
return IsRealProperty(type());
}
PropertyAttributes attributes() { return AttributesField::decode(value_); } PropertyAttributes attributes() { return AttributesField::decode(value_); }
int index() { return StorageField::decode(value_); } int index() { return StorageField::decode(value_); }

2
src/property.h
View File

@ -264,7 +264,7 @@ class LookupResult BASE_EMBEDDED {
// Is the result is a property excluding transitions and the null // Is the result is a property excluding transitions and the null
// descriptor? // descriptor?
bool IsProperty() { bool IsProperty() {
return IsFound() && GetPropertyDetails().IsProperty(); return IsFound() && IsRealProperty(GetPropertyDetails().type());
} }
bool IsCacheable() { return cacheable_; } bool IsCacheable() { return cacheable_; }