AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[torque] Emit full codesearch links for source positions

Browse Source 
Change-Id: I80affc4c813dff2a42afcdcea60e3856eaf346aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3272576
Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77841}
This commit is contained in:
Camillo Bruni 2021-11-10 17:27:42 +01:00 committed by V8 LUCI CQ
parent 77d9e997e6
commit ba713b8e55
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/torque/source-positions.h
View File

@ -109,7 +109,8 @@ inline std::string PositionAsString(SourcePosition pos) {
}
inline std::ostream& operator<<(std::ostream& out, SourcePosition pos) {
return out << SourceFileMap::PathFromV8Root(pos.source)
return out << "https://source.chromium.org/chromium/chromium/src/+/main:v8/"
<< SourceFileMap::PathFromV8Root(pos.source)
<< "?l=" << (pos.start.line + 1)
<< "&c=" << (pos.start.column + 1);
}

3
tools/gen-postmortem-metadata.py
View File

@ -447,7 +447,8 @@ def load_objects_from_file(objfilename, checktypes):
in_torque_fulldef = False
continue
line = re.sub('//.*', '', line.strip());
pre = line.strip()
line = re.sub('// .*', '', line.strip());
if (in_insttype):
typestr += line;