AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Add variant for --wasm-write-protect-code-memory

Browse Source 
This adds a test variant enabling --wasm-write-protect-code-memory, and
enables it on linux64 debug and release bots.

R=machenbach@chromium.org, jkummerow@chromium.org
CC=​dlehmann@google.com

Bug: v8:11667, v8:11663
Change-Id: I04f47d06d9720f7bc9e122d17b253646f2c203b1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2839562
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74179}
This commit is contained in:
Clemens Backes 2021-04-26 10:56:07 +02:00 committed by Commit Bot
parent 12aa090ee6
commit baa2840f9e
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
infra/testing/builders.pyl
View File

@ -389,6 +389,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
],
},
'v8_linux64_gc_stress_custom_snapshot_dbg_ng_triggered': {
@ -1204,6 +1206,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
],
},
'V8 Linux64 - debug - perfetto': {
@ -1235,6 +1239,8 @@
{'name': 'mjsunit', 'variant': 'experimental_regexp'},
# Concurrent inlining.
{'name': 'mjsunit', 'variant': 'concurrent_inlining'},
# Wasm write protect code space.
{'name': 'mjsunit', 'variant': 'wasm_write_protect_code'},
],
},
'V8 Linux64 - gcov coverage': {

4
tools/testrunner/local/variants.py
View File

@ -44,6 +44,7 @@ ALL_VARIANT_FLAGS = {
"instruction_scheduling": [["--turbo-instruction-scheduling"]],
"stress_instruction_scheduling": [["--turbo-stress-instruction-scheduling"]],
"top_level_await": [["--harmony-top-level-await"]],
"wasm_write_protect_code": [["--wasm-write-protect-code-memory"]],
}
# Flags that lead to a contradiction with the flags provided by the respective
@ -76,6 +77,9 @@ INCOMPATIBLE_FLAGS_PER_VARIANT = {
"no_local_heaps": ["--concurrent-inlining", "--turboprop"],
"experimental_regexp": ["--no-enable-experimental-regexp-engine",
"--no-default-to-experimental-regexp-engine"],
# There is a negative implication: --perf-prof disables
# --wasm-write-protect-code-memory.
"wasm_write_protect_code": ["--perf-prof"],
}
# Flags that lead to a contradiction under certain build variables.