AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[errors] Improve error message for Promise constructor

Browse Source 
Originally, 'Promise()' without 'new' will throw "undefined is not a
promise". Now it will throw "Promise constructor cannot be invoked
without 'new'".

Bug: v8:10817
Change-Id: Ic8b72a902ed395e44dbb32ccf96a2130a4a9422f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3459924
Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79547}
This commit is contained in:
jameslahm 2022-03-21 17:15:27 +08:00 committed by V8 LUCI CQ
parent cce657cc55
commit bba8bc2bb1
4 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/base.tq
View File

@ -402,7 +402,7 @@ extern enum MessageTemplate {
kRegExpNonRegExp, kRegExpNonRegExp,
kRegExpNonObject, kRegExpNonObject,
kPromiseNonCallable, kPromiseNonCallable,
kNotAPromise, kPromiseNewTargetUndefined,
kResolverNotAFunction, kResolverNotAFunction,
kTooManyElementsInPromiseCombinator, kTooManyElementsInPromiseCombinator,
kToRadixFormatRange, kToRadixFormatRange,

2
src/builtins/promise-constructor.tq
View File

@ -50,7 +50,7 @@ PromiseConstructor(
newTarget: JSAny)(executor: JSAny): JSAny { newTarget: JSAny)(executor: JSAny): JSAny {
// 1. If NewTarget is undefined, throw a TypeError exception. // 1. If NewTarget is undefined, throw a TypeError exception.
if (newTarget == Undefined) { if (newTarget == Undefined) {
ThrowTypeError(MessageTemplate::kNotAPromise, newTarget); ThrowTypeError(MessageTemplate::kPromiseNewTargetUndefined);
} }
// 2. If IsCallable(executor) is false, throw a TypeError exception. // 2. If IsCallable(executor) is false, throw a TypeError exception.

3
src/common/message-template.h
View File

@ -147,7 +147,8 @@ namespace internal {
T(NonStringImportAssertionValue, "Import assertion value must be a string") \ T(NonStringImportAssertionValue, "Import assertion value must be a string") \
T(NoSetterInCallback, "Cannot set property % of % which has only a getter") \ T(NoSetterInCallback, "Cannot set property % of % which has only a getter") \
T(NotAnIterator, "% is not an iterator") \ T(NotAnIterator, "% is not an iterator") \
T(NotAPromise, "% is not a promise") \ T(PromiseNewTargetUndefined, \
"Promise constructor cannot be invoked without 'new'") \
T(NotConstructor, "% is not a constructor") \ T(NotConstructor, "% is not a constructor") \
T(NotDateObject, "this is not a Date object.") \ T(NotDateObject, "this is not a Date object.") \
T(NotGeneric, "% requires that 'this' be a %") \ T(NotGeneric, "% requires that 'this' be a %") \

7
test/mjsunit/regress/regress-v8-10817.js Normal file
View File

@ -0,0 +1,7 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
assertThrows(() => {
Promise()
}, TypeError, "Promise constructor cannot be invoked without 'new'");