AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[fuzzer] Disallow atomic.wait in fuzzers

Browse Source 
It is very unlikely that atomic.wait does anything useful in the fuzzer,
and will most likely just timeout the fuzzer. That's why it's better to
just disallow atomic.wait on the fuzzer.

R=thibaudm@chromium.org

Bug: chromium:1229074
Change-Id: I57aaff013964fa4c0e6ab411789e53a9013cabd2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3053584
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75920}
This commit is contained in:
Andreas Haas 2021-07-26 13:16:47 +02:00 committed by V8 LUCI CQ
parent d47a930d71
commit bbeff193df
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/common/wasm/wasm-interpreter.cc
View File

@ -2169,7 +2169,7 @@ class WasmInterpreterInternals {
*len += 1;
break;
case kExprI32AtomicWait: {
if (!module()->has_shared_memory) {
if (!module()->has_shared_memory || !isolate_->allow_atomics_wait()) {
DoTrap(kTrapUnreachable, pc);
return false;
}
@ -2189,7 +2189,7 @@ class WasmInterpreterInternals {
break;
}
case kExprI64AtomicWait: {
if (!module()->has_shared_memory) {
if (!module()->has_shared_memory || !isolate_->allow_atomics_wait()) {
DoTrap(kTrapUnreachable, pc);
return false;
}

1
test/fuzzer/fuzzer-support.cc
View File

@ -26,6 +26,7 @@ FuzzerSupport::FuzzerSupport(int* argc, char*** argv) {
allocator_ = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = allocator_;
create_params.allow_atomics_wait = false;
isolate_ = v8::Isolate::New(create_params);
{